Skip to content

Commit 9858af2

Browse files
Colin Ian Kinggregkh
authored andcommitted
usbip: Fix incorrect double assignment to udc->ud.tcp_rx
Currently udc->ud.tcp_rx is being assigned twice, the second assignment is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this. Fixes: 46613c9 ("usbip: fix vudc usbip_sockfd_store races leading to gpf") Acked-by: Shuah Khan <[email protected]> Signed-off-by: Colin Ian King <[email protected]> Cc: stable <[email protected]> Addresses-Coverity: ("Unused value") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent eb9238e commit 9858af2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/usb/usbip/vudc_sysfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ static ssize_t usbip_sockfd_store(struct device *dev,
174174

175175
udc->ud.tcp_socket = socket;
176176
udc->ud.tcp_rx = tcp_rx;
177-
udc->ud.tcp_rx = tcp_tx;
177+
udc->ud.tcp_tx = tcp_tx;
178178
udc->ud.status = SDEV_ST_USED;
179179

180180
spin_unlock_irq(&udc->ud.lock);

0 commit comments

Comments
 (0)