@@ -2635,14 +2635,16 @@ EXPORT_SYMBOL(drm_dp_pcon_is_frl_ready);
2635
2635
* drm_dp_pcon_frl_configure_1() - Set HDMI LINK Configuration-Step1
2636
2636
* @aux: DisplayPort AUX channel
2637
2637
* @max_frl_gbps: maximum frl bw to be configured between PCON and HDMI sink
2638
- * @concurrent_mode: true if concurrent mode or operation is required,
2639
- * false otherwise.
2638
+ * @frl_mode: FRL Training mode, it can be either Concurrent or Sequential.
2639
+ * In Concurrent Mode, the FRL link bring up can be done along with
2640
+ * DP Link training. In Sequential mode, the FRL link bring up is done prior to
2641
+ * the DP Link training.
2640
2642
*
2641
2643
* Returns 0 if success, else returns negative error code.
2642
2644
*/
2643
2645
2644
2646
int drm_dp_pcon_frl_configure_1 (struct drm_dp_aux * aux , int max_frl_gbps ,
2645
- bool concurrent_mode )
2647
+ u8 frl_mode )
2646
2648
{
2647
2649
int ret ;
2648
2650
u8 buf ;
@@ -2651,7 +2653,7 @@ int drm_dp_pcon_frl_configure_1(struct drm_dp_aux *aux, int max_frl_gbps,
2651
2653
if (ret < 0 )
2652
2654
return ret ;
2653
2655
2654
- if (concurrent_mode )
2656
+ if (frl_mode == DP_PCON_ENABLE_CONCURRENT_LINK )
2655
2657
buf |= DP_PCON_ENABLE_CONCURRENT_LINK ;
2656
2658
else
2657
2659
buf &= ~DP_PCON_ENABLE_CONCURRENT_LINK ;
@@ -2694,21 +2696,23 @@ EXPORT_SYMBOL(drm_dp_pcon_frl_configure_1);
2694
2696
* drm_dp_pcon_frl_configure_2() - Set HDMI Link configuration Step-2
2695
2697
* @aux: DisplayPort AUX channel
2696
2698
* @max_frl_mask : Max FRL BW to be tried by the PCON with HDMI Sink
2697
- * @extended_train_mode : true for Extended Mode, false for Normal Mode .
2698
- * In Normal mode , the PCON tries each frl bw from the max_frl_mask starting
2699
- * from min, and stops when link training is successful. In Extended mode, all
2700
- * frl bw selected in the mask are trained by the PCON.
2699
+ * @frl_type : FRL training type, can be Extended, or Normal .
2700
+ * In Normal FRL training , the PCON tries each frl bw from the max_frl_mask
2701
+ * starting from min, and stops when link training is successful. In Extended
2702
+ * FRL training, all frl bw selected in the mask are trained by the PCON.
2701
2703
*
2702
2704
* Returns 0 if success, else returns negative error code.
2703
2705
*/
2704
2706
int drm_dp_pcon_frl_configure_2 (struct drm_dp_aux * aux , int max_frl_mask ,
2705
- bool extended_train_mode )
2707
+ u8 frl_type )
2706
2708
{
2707
2709
int ret ;
2708
2710
u8 buf = max_frl_mask ;
2709
2711
2710
- if (extended_train_mode )
2712
+ if (frl_type == DP_PCON_FRL_LINK_TRAIN_EXTENDED )
2711
2713
buf |= DP_PCON_FRL_LINK_TRAIN_EXTENDED ;
2714
+ else
2715
+ buf &= ~DP_PCON_FRL_LINK_TRAIN_EXTENDED ;
2712
2716
2713
2717
ret = drm_dp_dpcd_writeb (aux , DP_PCON_HDMI_LINK_CONFIG_2 , buf );
2714
2718
if (ret < 0 )
0 commit comments