Skip to content

Commit 9cca0c2

Browse files
pskrgagdavem330
authored andcommitted
net: ethernet: fix potential use-after-free in ec_bhf_remove
static void ec_bhf_remove(struct pci_dev *dev) { ... struct ec_bhf_priv *priv = netdev_priv(net_dev); unregister_netdev(net_dev); free_netdev(net_dev); pci_iounmap(dev, priv->dma_io); pci_iounmap(dev, priv->io); ... } priv is netdev private data, but it is used after free_netdev(). It can cause use-after-free when accessing priv pointer. So, fix it by moving free_netdev() after pci_iounmap() calls. Fixes: 6af55ff ("Driver for Beckhoff CX5020 EtherCAT master module.") Signed-off-by: Pavel Skripkin <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 0d1dc9e commit 9cca0c2

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/net/ethernet/ec_bhf.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,10 +576,12 @@ static void ec_bhf_remove(struct pci_dev *dev)
576576
struct ec_bhf_priv *priv = netdev_priv(net_dev);
577577

578578
unregister_netdev(net_dev);
579-
free_netdev(net_dev);
580579

581580
pci_iounmap(dev, priv->dma_io);
582581
pci_iounmap(dev, priv->io);
582+
583+
free_netdev(net_dev);
584+
583585
pci_release_regions(dev);
584586
pci_clear_master(dev);
585587
pci_disable_device(dev);

0 commit comments

Comments
 (0)