Skip to content

Commit 9dc12e4

Browse files
davidhildenbrandMichal Simek
authored andcommitted
microblaze: tag highmem_setup() with __meminit
With commit a0cd7a7 ("mm: simplify free_highmem_page() and free_reserved_page()") the kernel test robot complains about a warning: WARNING: modpost: vmlinux.o(.text.unlikely+0x23ac): Section mismatch in reference from the function highmem_setup() to the function .meminit.text:memblock_is_reserved() This has been broken ever since microblaze added highmem support, because memblock_is_reserved() was already tagged with "__init" back then - most probably the function always got inlined, so we never stumbled over it. We need __meminit because __init_memblock defaults to that without CONFIG_ARCH_KEEP_MEMBLOCK" and __init_memblock is not used outside memblock code. Reported-by: kernel test robot <[email protected]> Fixes: 2f2f371 ("microblaze: Highmem support") Cc: Andrew Morton <[email protected]> Cc: Michal Simek <[email protected]> Cc: Mike Rapoport <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Arvind Sankar <[email protected]> Cc: Ira Weiny <[email protected]> Cc: Randy Dunlap <[email protected]> Cc: Oscar Salvador <[email protected]> Cc: Anshuman Khandual <[email protected]> Signed-off-by: David Hildenbrand <[email protected]> Reviewed-by: Oscar Salvador <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Michal Simek <[email protected]>
1 parent 64f416c commit 9dc12e4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/microblaze/mm/init.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ static void __init highmem_init(void)
5252
pkmap_page_table = virt_to_kpte(PKMAP_BASE);
5353
}
5454

55-
static void highmem_setup(void)
55+
static void __meminit highmem_setup(void)
5656
{
5757
unsigned long pfn;
5858

0 commit comments

Comments
 (0)