Skip to content

Commit 9e4ae52

Browse files
ErKun YangLorenzo Pieralisi
authored andcommitted
PCI: xgene-msi: Remove redundant dev_err() call in xgene_msi_probe()
devm_ioremap_resource() internally calls __devm_ioremap_resource() which is where error checking and handling is actually taking place. i Therefore, the dev_err() call in xgene_msi_probe() is redundant. Remove it. Link: https://lore.kernel.org/r/[email protected] Reported-by: Hulk Robot <[email protected]> Signed-off-by: ErKun Yang <[email protected]> [[email protected]: commit log] Signed-off-by: Lorenzo Pieralisi <[email protected]> Reviewed-by: Krzysztof Wilczyński <[email protected]>
1 parent e73f0f0 commit 9e4ae52

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/pci/controller/pci-xgene-msi.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev)
451451
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
452452
xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
453453
if (IS_ERR(xgene_msi->msi_regs)) {
454-
dev_err(&pdev->dev, "no reg space\n");
455454
rc = PTR_ERR(xgene_msi->msi_regs);
456455
goto error;
457456
}

0 commit comments

Comments
 (0)