Skip to content

Commit 9f9bc7d

Browse files
plbossartvinodkoul
authored andcommitted
soundwire: bus: filter out more -EDATA errors on clock stop
We've added quite a few filters to avoid throwing errors if a Device does not respond to commands during the clock stop sequences, but we missed one. This will lead to an isolated message [ 6115.294412] soundwire sdw-master-1: SDW_SCP_STAT bread failed:-61 The callers already filter this error code, so there's no point in keeping it at the lower level. Since this is a recoverable error, make this dev_err() conditional and only log cases with Command Failed. Signed-off-by: Pierre-Louis Bossart <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Signed-off-by: Bard Liao <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 433b308 commit 9f9bc7d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/soundwire/bus.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,8 @@ static int sdw_bus_wait_for_clk_prep_deprep(struct sdw_bus *bus, u16 dev_num)
896896
do {
897897
val = sdw_bread_no_pm(bus, dev_num, SDW_SCP_STAT);
898898
if (val < 0) {
899-
dev_err(bus->dev, "SDW_SCP_STAT bread failed:%d\n", val);
899+
if (val != -ENODATA)
900+
dev_err(bus->dev, "SDW_SCP_STAT bread failed:%d\n", val);
900901
return val;
901902
}
902903
val &= SDW_SCP_STAT_CLK_STP_NF;

0 commit comments

Comments
 (0)