Skip to content

Commit a16ef91

Browse files
tititiou36kuba-moo
authored andcommitted
net: pasemi: Remove usage of the deprecated "pci-dma-compat.h" API
In [1], Christoph Hellwig has proposed to remove the wrappers in include/linux/pci-dma-compat.h. Some reasons why this API should be removed have been given by Julia Lawall in [2]. A coccinelle script has been used to perform the needed transformation Only relevant parts are given below. An 'unlikely()' has been removed when calling 'dma_mapping_error()' because this function, which is inlined, already has such an annotation. @@ @@ - PCI_DMA_TODEVICE + DMA_TO_DEVICE @@ @@ - PCI_DMA_FROMDEVICE + DMA_FROM_DEVICE @@ expression e1, e2, e3, e4; @@ - pci_map_single(e1, e2, e3, e4) + dma_map_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_unmap_single(e1, e2, e3, e4) + dma_unmap_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4, e5; @@ - pci_map_page(e1, e2, e3, e4, e5) + dma_map_page(&e1->dev, e2, e3, e4, e5) @@ expression e1, e2, e3, e4; @@ - pci_unmap_page(e1, e2, e3, e4) + dma_unmap_page(&e1->dev, e2, e3, e4) @@ expression e1, e2; @@ - pci_dma_mapping_error(e1, e2) + dma_mapping_error(&e1->dev, e2) [1]: https://lore.kernel.org/kernel-janitors/[email protected]/ [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/ Signed-off-by: Christophe JAILLET <[email protected]> Link: https://lore.kernel.org/r/bc6cd281eae024b26fd9c7ef6678d2d1dc9d74fd.1630150008.git.christophe.jaillet@wanadoo.fr Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c660701 commit a16ef91

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

drivers/net/ethernet/pasemi/pasemi_mac.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,13 @@ static int pasemi_mac_unmap_tx_skb(struct pasemi_mac *mac,
247247
int f;
248248
struct pci_dev *pdev = mac->dma_pdev;
249249

250-
pci_unmap_single(pdev, dmas[0], skb_headlen(skb), PCI_DMA_TODEVICE);
250+
dma_unmap_single(&pdev->dev, dmas[0], skb_headlen(skb), DMA_TO_DEVICE);
251251

252252
for (f = 0; f < nfrags; f++) {
253253
const skb_frag_t *frag = &skb_shinfo(skb)->frags[f];
254254

255-
pci_unmap_page(pdev, dmas[f+1], skb_frag_size(frag), PCI_DMA_TODEVICE);
255+
dma_unmap_page(&pdev->dev, dmas[f + 1], skb_frag_size(frag),
256+
DMA_TO_DEVICE);
256257
}
257258
dev_kfree_skb_irq(skb);
258259

@@ -548,10 +549,8 @@ static void pasemi_mac_free_rx_buffers(struct pasemi_mac *mac)
548549
for (i = 0; i < RX_RING_SIZE; i++) {
549550
info = &RX_DESC_INFO(rx, i);
550551
if (info->skb && info->dma) {
551-
pci_unmap_single(mac->dma_pdev,
552-
info->dma,
553-
info->skb->len,
554-
PCI_DMA_FROMDEVICE);
552+
dma_unmap_single(&mac->dma_pdev->dev, info->dma,
553+
info->skb->len, DMA_FROM_DEVICE);
555554
dev_kfree_skb_any(info->skb);
556555
}
557556
info->dma = 0;
@@ -600,11 +599,11 @@ static void pasemi_mac_replenish_rx_ring(struct net_device *dev,
600599
if (unlikely(!skb))
601600
break;
602601

603-
dma = pci_map_single(mac->dma_pdev, skb->data,
602+
dma = dma_map_single(&mac->dma_pdev->dev, skb->data,
604603
mac->bufsz - LOCAL_SKB_ALIGN,
605-
PCI_DMA_FROMDEVICE);
604+
DMA_FROM_DEVICE);
606605

607-
if (unlikely(pci_dma_mapping_error(mac->dma_pdev, dma))) {
606+
if (dma_mapping_error(&mac->dma_pdev->dev, dma)) {
608607
dev_kfree_skb_irq(info->skb);
609608
break;
610609
}
@@ -741,8 +740,9 @@ static int pasemi_mac_clean_rx(struct pasemi_mac_rxring *rx,
741740

742741
len = (macrx & XCT_MACRX_LLEN_M) >> XCT_MACRX_LLEN_S;
743742

744-
pci_unmap_single(pdev, dma, mac->bufsz - LOCAL_SKB_ALIGN,
745-
PCI_DMA_FROMDEVICE);
743+
dma_unmap_single(&pdev->dev, dma,
744+
mac->bufsz - LOCAL_SKB_ALIGN,
745+
DMA_FROM_DEVICE);
746746

747747
if (macrx & XCT_MACRX_CRC) {
748748
/* CRC error flagged */
@@ -1444,10 +1444,10 @@ static int pasemi_mac_start_tx(struct sk_buff *skb, struct net_device *dev)
14441444

14451445
nfrags = skb_shinfo(skb)->nr_frags;
14461446

1447-
map[0] = pci_map_single(mac->dma_pdev, skb->data, skb_headlen(skb),
1448-
PCI_DMA_TODEVICE);
1447+
map[0] = dma_map_single(&mac->dma_pdev->dev, skb->data,
1448+
skb_headlen(skb), DMA_TO_DEVICE);
14491449
map_size[0] = skb_headlen(skb);
1450-
if (pci_dma_mapping_error(mac->dma_pdev, map[0]))
1450+
if (dma_mapping_error(&mac->dma_pdev->dev, map[0]))
14511451
goto out_err_nolock;
14521452

14531453
for (i = 0; i < nfrags; i++) {
@@ -1534,8 +1534,8 @@ static int pasemi_mac_start_tx(struct sk_buff *skb, struct net_device *dev)
15341534
spin_unlock_irqrestore(&txring->lock, flags);
15351535
out_err_nolock:
15361536
while (nfrags--)
1537-
pci_unmap_single(mac->dma_pdev, map[nfrags], map_size[nfrags],
1538-
PCI_DMA_TODEVICE);
1537+
dma_unmap_single(&mac->dma_pdev->dev, map[nfrags],
1538+
map_size[nfrags], DMA_TO_DEVICE);
15391539

15401540
return NETDEV_TX_BUSY;
15411541
}

0 commit comments

Comments
 (0)