Skip to content

Commit a2db194

Browse files
committed
drm/i915: rename CNL references in intel_dram.c
With the removal of CNL, let's consider ICL as the first platform using those constants. Signed-off-by: Lucas De Marchi <[email protected]> Reviewed-by: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent b426c83 commit a2db194

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

drivers/gpu/drm/i915/i915_reg.h

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11152,18 +11152,18 @@ enum skl_power_gate {
1115211152
#define SKL_DRAM_RANK_1 (0x0 << 10)
1115311153
#define SKL_DRAM_RANK_2 (0x1 << 10)
1115411154
#define SKL_DRAM_RANK_MASK (0x1 << 10)
11155-
#define CNL_DRAM_SIZE_MASK 0x7F
11156-
#define CNL_DRAM_WIDTH_MASK (0x3 << 7)
11157-
#define CNL_DRAM_WIDTH_SHIFT 7
11158-
#define CNL_DRAM_WIDTH_X8 (0x0 << 7)
11159-
#define CNL_DRAM_WIDTH_X16 (0x1 << 7)
11160-
#define CNL_DRAM_WIDTH_X32 (0x2 << 7)
11161-
#define CNL_DRAM_RANK_MASK (0x3 << 9)
11162-
#define CNL_DRAM_RANK_SHIFT 9
11163-
#define CNL_DRAM_RANK_1 (0x0 << 9)
11164-
#define CNL_DRAM_RANK_2 (0x1 << 9)
11165-
#define CNL_DRAM_RANK_3 (0x2 << 9)
11166-
#define CNL_DRAM_RANK_4 (0x3 << 9)
11155+
#define ICL_DRAM_SIZE_MASK 0x7F
11156+
#define ICL_DRAM_WIDTH_MASK (0x3 << 7)
11157+
#define ICL_DRAM_WIDTH_SHIFT 7
11158+
#define ICL_DRAM_WIDTH_X8 (0x0 << 7)
11159+
#define ICL_DRAM_WIDTH_X16 (0x1 << 7)
11160+
#define ICL_DRAM_WIDTH_X32 (0x2 << 7)
11161+
#define ICL_DRAM_RANK_MASK (0x3 << 9)
11162+
#define ICL_DRAM_RANK_SHIFT 9
11163+
#define ICL_DRAM_RANK_1 (0x0 << 9)
11164+
#define ICL_DRAM_RANK_2 (0x1 << 9)
11165+
#define ICL_DRAM_RANK_3 (0x2 << 9)
11166+
#define ICL_DRAM_RANK_4 (0x3 << 9)
1116711167

1116811168
#define SA_PERF_STATUS_0_0_0_MCHBAR_PC _MMIO(MCHBAR_MIRROR_BASE_SNB + 0x5918)
1116911169
#define DG1_QCLK_RATIO_MASK REG_GENMASK(9, 2)

drivers/gpu/drm/i915/intel_dram.c

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -77,34 +77,34 @@ static int skl_get_dimm_ranks(u16 val)
7777
}
7878

7979
/* Returns total Gb for the whole DIMM */
80-
static int cnl_get_dimm_size(u16 val)
80+
static int icl_get_dimm_size(u16 val)
8181
{
82-
return (val & CNL_DRAM_SIZE_MASK) * 8 / 2;
82+
return (val & ICL_DRAM_SIZE_MASK) * 8 / 2;
8383
}
8484

85-
static int cnl_get_dimm_width(u16 val)
85+
static int icl_get_dimm_width(u16 val)
8686
{
87-
if (cnl_get_dimm_size(val) == 0)
87+
if (icl_get_dimm_size(val) == 0)
8888
return 0;
8989

90-
switch (val & CNL_DRAM_WIDTH_MASK) {
91-
case CNL_DRAM_WIDTH_X8:
92-
case CNL_DRAM_WIDTH_X16:
93-
case CNL_DRAM_WIDTH_X32:
94-
val = (val & CNL_DRAM_WIDTH_MASK) >> CNL_DRAM_WIDTH_SHIFT;
90+
switch (val & ICL_DRAM_WIDTH_MASK) {
91+
case ICL_DRAM_WIDTH_X8:
92+
case ICL_DRAM_WIDTH_X16:
93+
case ICL_DRAM_WIDTH_X32:
94+
val = (val & ICL_DRAM_WIDTH_MASK) >> ICL_DRAM_WIDTH_SHIFT;
9595
return 8 << val;
9696
default:
9797
MISSING_CASE(val);
9898
return 0;
9999
}
100100
}
101101

102-
static int cnl_get_dimm_ranks(u16 val)
102+
static int icl_get_dimm_ranks(u16 val)
103103
{
104-
if (cnl_get_dimm_size(val) == 0)
104+
if (icl_get_dimm_size(val) == 0)
105105
return 0;
106106

107-
val = (val & CNL_DRAM_RANK_MASK) >> CNL_DRAM_RANK_SHIFT;
107+
val = (val & ICL_DRAM_RANK_MASK) >> ICL_DRAM_RANK_SHIFT;
108108

109109
return val + 1;
110110
}
@@ -121,10 +121,10 @@ skl_dram_get_dimm_info(struct drm_i915_private *i915,
121121
struct dram_dimm_info *dimm,
122122
int channel, char dimm_name, u16 val)
123123
{
124-
if (GRAPHICS_VER(i915) >= 10) {
125-
dimm->size = cnl_get_dimm_size(val);
126-
dimm->width = cnl_get_dimm_width(val);
127-
dimm->ranks = cnl_get_dimm_ranks(val);
124+
if (GRAPHICS_VER(i915) >= 11) {
125+
dimm->size = icl_get_dimm_size(val);
126+
dimm->width = icl_get_dimm_width(val);
127+
dimm->ranks = icl_get_dimm_ranks(val);
128128
} else {
129129
dimm->size = skl_get_dimm_size(val);
130130
dimm->width = skl_get_dimm_width(val);

0 commit comments

Comments
 (0)