Skip to content

Commit a65ab97

Browse files
uver29jhovold
authored andcommitted
USB: serial: replace symbolic permissions by octal permissions
Replace symbolic permission macros with octal permission numbers because octal permission numbers are easier to read and understand instead of their symbolic macro names. No functional change. Suggested-by: Lukas Bulwahn <[email protected]> Signed-off-by: Utkarsh Verma <[email protected]> Signed-off-by: Johan Hovold <[email protected]>
1 parent 4e9340b commit a65ab97

File tree

7 files changed

+15
-15
lines changed

7 files changed

+15
-15
lines changed

drivers/usb/serial/cypress_m8.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1199,9 +1199,9 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
11991199
MODULE_DESCRIPTION(DRIVER_DESC);
12001200
MODULE_LICENSE("GPL");
12011201

1202-
module_param(stats, bool, S_IRUGO | S_IWUSR);
1202+
module_param(stats, bool, 0644);
12031203
MODULE_PARM_DESC(stats, "Enable statistics or not");
1204-
module_param(interval, int, S_IRUGO | S_IWUSR);
1204+
module_param(interval, int, 0644);
12051205
MODULE_PARM_DESC(interval, "Overrides interrupt interval");
1206-
module_param(unstable_bauds, bool, S_IRUGO | S_IWUSR);
1206+
module_param(unstable_bauds, bool, 0644);
12071207
MODULE_PARM_DESC(unstable_bauds, "Allow unstable baud rates");

drivers/usb/serial/ftdi_sio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2937,5 +2937,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
29372937
MODULE_DESCRIPTION(DRIVER_DESC);
29382938
MODULE_LICENSE("GPL");
29392939

2940-
module_param(ndi_latency_timer, int, S_IRUGO | S_IWUSR);
2940+
module_param(ndi_latency_timer, int, 0644);
29412941
MODULE_PARM_DESC(ndi_latency_timer, "NDI device latency timer override");

drivers/usb/serial/garmin_gps.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1444,5 +1444,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
14441444
MODULE_DESCRIPTION(DRIVER_DESC);
14451445
MODULE_LICENSE("GPL");
14461446

1447-
module_param(initial_mode, int, S_IRUGO);
1447+
module_param(initial_mode, int, 0444);
14481448
MODULE_PARM_DESC(initial_mode, "Initial mode");

drivers/usb/serial/io_ti.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2746,9 +2746,9 @@ MODULE_DESCRIPTION(DRIVER_DESC);
27462746
MODULE_LICENSE("GPL");
27472747
MODULE_FIRMWARE("edgeport/down3.bin");
27482748

2749-
module_param(ignore_cpu_rev, bool, S_IRUGO | S_IWUSR);
2749+
module_param(ignore_cpu_rev, bool, 0644);
27502750
MODULE_PARM_DESC(ignore_cpu_rev,
27512751
"Ignore the cpu revision when connecting to a device");
27522752

2753-
module_param(default_uart_mode, int, S_IRUGO | S_IWUSR);
2753+
module_param(default_uart_mode, int, 0644);
27542754
MODULE_PARM_DESC(default_uart_mode, "Default uart_mode, 0=RS232, ...");

drivers/usb/serial/ipaq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -599,10 +599,10 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
599599
MODULE_DESCRIPTION(DRIVER_DESC);
600600
MODULE_LICENSE("GPL");
601601

602-
module_param(connect_retries, int, S_IRUGO|S_IWUSR);
602+
module_param(connect_retries, int, 0644);
603603
MODULE_PARM_DESC(connect_retries,
604604
"Maximum number of connect retries (one second each)");
605605

606-
module_param(initial_wait, int, S_IRUGO|S_IWUSR);
606+
module_param(initial_wait, int, 0644);
607607
MODULE_PARM_DESC(initial_wait,
608608
"Time to wait before attempting a connection (in seconds)");

drivers/usb/serial/iuu_phoenix.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,20 +1188,20 @@ MODULE_AUTHOR("Alain Degreffe [email protected]");
11881188
MODULE_DESCRIPTION(DRIVER_DESC);
11891189
MODULE_LICENSE("GPL");
11901190

1191-
module_param(xmas, bool, S_IRUGO | S_IWUSR);
1191+
module_param(xmas, bool, 0644);
11921192
MODULE_PARM_DESC(xmas, "Xmas colors enabled or not");
11931193

1194-
module_param(boost, int, S_IRUGO | S_IWUSR);
1194+
module_param(boost, int, 0644);
11951195
MODULE_PARM_DESC(boost, "Card overclock boost (in percent 100-500)");
11961196

1197-
module_param(clockmode, int, S_IRUGO | S_IWUSR);
1197+
module_param(clockmode, int, 0644);
11981198
MODULE_PARM_DESC(clockmode, "Card clock mode (1=3.579 MHz, 2=3.680 MHz, "
11991199
"3=6 Mhz)");
12001200

1201-
module_param(cdmode, int, S_IRUGO | S_IWUSR);
1201+
module_param(cdmode, int, 0644);
12021202
MODULE_PARM_DESC(cdmode, "Card detect mode (0=none, 1=CD, 2=!CD, 3=DSR, "
12031203
"4=!DSR, 5=CTS, 6=!CTS, 7=RING, 8=!RING)");
12041204

1205-
module_param(vcc_default, int, S_IRUGO | S_IWUSR);
1205+
module_param(vcc_default, int, 0644);
12061206
MODULE_PARM_DESC(vcc_default, "Set default VCC (either 3 for 3.3V or 5 "
12071207
"for 5V). Default to 5.");

drivers/usb/serial/sierra.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1056,5 +1056,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
10561056
MODULE_DESCRIPTION(DRIVER_DESC);
10571057
MODULE_LICENSE("GPL v2");
10581058

1059-
module_param(nmea, bool, S_IRUGO | S_IWUSR);
1059+
module_param(nmea, bool, 0644);
10601060
MODULE_PARM_DESC(nmea, "NMEA streaming");

0 commit comments

Comments
 (0)