Skip to content

Commit a72fa63

Browse files
dlatypovshuahkh
authored andcommitted
Documentation: kunit: drop obsolete note about uml_abort for coverage
Commit b6d5799 ("kunit: Add 'kunit_shutdown' option") changes KUnit to call kernel_halt() by default when done testing. This fixes the issue with not having .gcda files due to not calling atexit() handlers, and therefore we can stop recommending people manually tweak UML code. The need to use older versions of GCC (<=6) remains however, due to linktime issues, same as before. Note: There also might still be issues with .gcda files as well in newer versions. Signed-off-by: Daniel Latypov <[email protected]> Reviewed-by: David Gow <[email protected]> Reviewed-by: Brendan Higgins <[email protected]> Signed-off-by: Shuah Khan <[email protected]>
1 parent ed01ad3 commit a72fa63

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

Documentation/dev-tools/kunit/running_tips.rst

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -86,19 +86,7 @@ Generating code coverage reports under UML
8686
.. note::
8787
TODO([email protected]): There are various issues with UML and
8888
versions of gcc 7 and up. You're likely to run into missing ``.gcda``
89-
files or compile errors. We know one `faulty GCC commit
90-
<https://github.com/gcc-mirror/gcc/commit/8c9434c2f9358b8b8bad2c1990edf10a21645f9d>`_
91-
but not how we'd go about getting this fixed. The compile errors still
92-
need some investigation.
93-
94-
.. note::
95-
TODO([email protected]): for recent versions of Linux
96-
(5.10-5.12, maybe earlier), there's a bug with gcov counters not being
97-
flushed in UML. This translates to very low (<1%) reported coverage. This is
98-
related to the above issue and can be worked around by replacing the
99-
one call to ``uml_abort()`` (it's in ``os_dump_core()``) with a plain
100-
``exit()``.
101-
89+
files or compile errors.
10290

10391
This is different from the "normal" way of getting coverage information that is
10492
documented in Documentation/dev-tools/gcov.rst.

0 commit comments

Comments
 (0)