Skip to content

Commit a973c98

Browse files
superm1jwrdegoede
authored andcommitted
platform/x86: amd-pmc: Use return code on suspend
Right now the driver will still return success even if the OS_HINT command failed to send to the SMU. In the rare event of a failure, the suspend should really be aborted here so that relevant logs can may be captured. Signed-off-by: Mario Limonciello <[email protected]> Acked-by: Shyam Sundar S K <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]>
1 parent 83cbaf1 commit a973c98

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/platform/x86/amd-pmc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ static int __maybe_unused amd_pmc_suspend(struct device *dev)
353353
if (rc)
354354
dev_err(pdev->dev, "suspend failed\n");
355355

356-
return 0;
356+
return rc;
357357
}
358358

359359
static int __maybe_unused amd_pmc_resume(struct device *dev)

0 commit comments

Comments
 (0)