Skip to content

Commit aa0dc6a

Browse files
sreekanthbrcmmartinkpetersen
authored andcommitted
scsi: mpi3mr: Fix W=1 compilation warnings
Fix for the following W=1 compilation warning: 'strncpy' output may be truncated copying 16 bytes from a string of length 64 Link: https://lore.kernel.org/r/[email protected] Reported-by: kernel test robot <[email protected]> Signed-off-by: Sreekanth Reddy <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent bb6beab commit aa0dc6a

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

drivers/scsi/mpi3mr/mpi3mr_fw.c

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2607,14 +2607,13 @@ static int mpi3mr_issue_iocinit(struct mpi3mr_ioc *mrioc)
26072607
goto out;
26082608
}
26092609
drv_info->information_length = cpu_to_le32(data_len);
2610-
strncpy(drv_info->driver_signature, "Broadcom", sizeof(drv_info->driver_signature));
2611-
strncpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name));
2612-
drv_info->os_name[sizeof(drv_info->os_name) - 1] = 0;
2613-
strncpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version));
2614-
drv_info->os_version[sizeof(drv_info->os_version) - 1] = 0;
2615-
strncpy(drv_info->driver_name, MPI3MR_DRIVER_NAME, sizeof(drv_info->driver_name));
2616-
strncpy(drv_info->driver_version, MPI3MR_DRIVER_VERSION, sizeof(drv_info->driver_version));
2617-
strncpy(drv_info->driver_release_date, MPI3MR_DRIVER_RELDATE, sizeof(drv_info->driver_release_date));
2610+
strscpy(drv_info->driver_signature, "Broadcom", sizeof(drv_info->driver_signature));
2611+
strscpy(drv_info->os_name, utsname()->sysname, sizeof(drv_info->os_name));
2612+
strscpy(drv_info->os_version, utsname()->release, sizeof(drv_info->os_version));
2613+
strscpy(drv_info->driver_name, MPI3MR_DRIVER_NAME, sizeof(drv_info->driver_name));
2614+
strscpy(drv_info->driver_version, MPI3MR_DRIVER_VERSION, sizeof(drv_info->driver_version));
2615+
strscpy(drv_info->driver_release_date, MPI3MR_DRIVER_RELDATE,
2616+
sizeof(drv_info->driver_release_date));
26182617
drv_info->driver_capabilities = 0;
26192618
memcpy((u8 *)&mrioc->driver_info, (u8 *)drv_info,
26202619
sizeof(mrioc->driver_info));

0 commit comments

Comments
 (0)