Skip to content

Commit ae41d92

Browse files
Yang Yingliangmmind
authored andcommitted
drm/rockchip: cdn-dp-core: add missing clk_disable_unprepare() on error in cdn_dp_grf_write()
After calling clk_prepare_enable(), clk_disable_unprepare() need be called when calling regmap_write() failed. Fixes: 1a0f7ed ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Yang Yingliang <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 046e0db commit ae41d92

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/rockchip/cdn-dp-core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ static int cdn_dp_grf_write(struct cdn_dp_device *dp,
7373
ret = regmap_write(dp->grf, reg, val);
7474
if (ret) {
7575
DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret);
76+
clk_disable_unprepare(dp->grf_clk);
7677
return ret;
7778
}
7879

0 commit comments

Comments
 (0)