Skip to content

Commit af4c1a8

Browse files
committed
drm/qxl: balance dumb_shadow_bo pin
The shadow bo is created in pinned state, so we have to unpin it when dropping the reference. Otherwise ttm is unhappy and throws a WARN() on release. Signed-off-by: Gerd Hoffmann <[email protected]> Acked-by: Thomas Zimmermann <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 1d878df commit af4c1a8

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/qxl/qxl_display.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,7 @@ static void qxl_prepare_shadow(struct qxl_device *qdev, struct qxl_bo *user_bo,
801801
qdev->dumb_shadow_bo->surf.width != surf.width ||
802802
qdev->dumb_shadow_bo->surf.height != surf.height) {
803803
if (qdev->dumb_shadow_bo) {
804+
qxl_bo_unpin(qdev->dumb_shadow_bo);
804805
drm_gem_object_put
805806
(&qdev->dumb_shadow_bo->tbo.base);
806807
qdev->dumb_shadow_bo = NULL;

0 commit comments

Comments
 (0)