Skip to content

Commit b430e1d

Browse files
qzedjwrdegoede
authored andcommitted
platform/surface: aggregator: Fix event disable function
Disabling events silently fails due to the wrong command ID being used. Instead of the command ID for the disable call, the command ID for the enable call was being used. This causes the disable call to enable the event instead. As the event is already enabled when we call this function, the EC silently drops this command and does nothing. Use the correct command ID for disabling the event to fix this. Fixes: c167b9c ("platform/surface: Add Surface Aggregator subsystem") Signed-off-by: Maximilian Luz <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]>
1 parent c0e0436 commit b430e1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/platform/surface/aggregator/controller.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1907,7 +1907,7 @@ static int ssam_ssh_event_disable(struct ssam_controller *ctrl,
19071907
{
19081908
int status;
19091909

1910-
status = __ssam_ssh_event_request(ctrl, reg, reg.cid_enable, id, flags);
1910+
status = __ssam_ssh_event_request(ctrl, reg, reg.cid_disable, id, flags);
19111911

19121912
if (status < 0 && status != -EINVAL) {
19131913
ssam_err(ctrl,

0 commit comments

Comments
 (0)