Skip to content

Commit b476490

Browse files
committed
Merge tag 'irqchip-fixes-5.13-1' of git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms into irq/urgent
Pull irqchip fixes from Marc Zyngier: - Fix PXA Mainstone CPLD irq allocation in legacy mode - Restrict the Apple AIC controller to the Apple platform - Remove a few supperfluous messages on devm_ioremap_resource() failure Link: https://lore.kernel.org/r/[email protected]
2 parents d07f6ca + fbb80d5 commit b476490

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

arch/arm/mach-pxa/pxa_cplds_irqs.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,13 @@ static int cplds_probe(struct platform_device *pdev)
121121
return fpga->irq;
122122

123123
base_irq = platform_get_irq(pdev, 1);
124-
if (base_irq < 0)
124+
if (base_irq < 0) {
125125
base_irq = 0;
126+
} else {
127+
ret = devm_irq_alloc_descs(&pdev->dev, base_irq, base_irq, CPLDS_NB_IRQ, 0);
128+
if (ret < 0)
129+
return ret;
130+
}
126131

127132
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
128133
fpga->base = devm_ioremap_resource(&pdev->dev, res);

drivers/irqchip/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ config IRQ_IDT3243X
596596
config APPLE_AIC
597597
bool "Apple Interrupt Controller (AIC)"
598598
depends on ARM64
599-
default ARCH_APPLE
599+
depends on ARCH_APPLE || COMPILE_TEST
600600
help
601601
Support for the Apple Interrupt Controller found on Apple Silicon SoCs,
602602
such as the M1.

drivers/irqchip/irq-mvebu-icu.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -359,10 +359,8 @@ static int mvebu_icu_probe(struct platform_device *pdev)
359359

360360
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
361361
icu->base = devm_ioremap_resource(&pdev->dev, res);
362-
if (IS_ERR(icu->base)) {
363-
dev_err(&pdev->dev, "Failed to map icu base address.\n");
362+
if (IS_ERR(icu->base))
364363
return PTR_ERR(icu->base);
365-
}
366364

367365
/*
368366
* Legacy bindings: ICU is one node with one MSI parent: force manually

drivers/irqchip/irq-mvebu-sei.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -384,10 +384,8 @@ static int mvebu_sei_probe(struct platform_device *pdev)
384384

385385
sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
386386
sei->base = devm_ioremap_resource(sei->dev, sei->res);
387-
if (IS_ERR(sei->base)) {
388-
dev_err(sei->dev, "Failed to remap SEI resource\n");
387+
if (IS_ERR(sei->base))
389388
return PTR_ERR(sei->base);
390-
}
391389

392390
/* Retrieve the SEI capabilities with the interrupt ranges */
393391
sei->caps = of_device_get_match_data(&pdev->dev);

drivers/irqchip/irq-stm32-exti.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev)
892892

893893
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
894894
host_data->base = devm_ioremap_resource(dev, res);
895-
if (IS_ERR(host_data->base)) {
896-
dev_err(dev, "Unable to map registers\n");
895+
if (IS_ERR(host_data->base))
897896
return PTR_ERR(host_data->base);
898-
}
899897

900898
for (i = 0; i < drv_data->bank_nr; i++)
901899
stm32_exti_chip_init(host_data, i, np);

0 commit comments

Comments
 (0)