Skip to content

Commit b539c44

Browse files
andy-shevdavem330
authored andcommitted
net: wwan: iosm: Unify IO accessors used in the driver
Currently we have readl()/writel()/ioread*()/iowrite*() APIs in use. Let's unify to use only ioread*()/iowrite*() variants. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1d99411 commit b539c44

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

drivers/net/wwan/iosm/iosm_ipc_mmio.c

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ void ipc_mmio_update_cp_capability(struct iosm_mmio *ipc_mmio)
6969
unsigned int ver;
7070

7171
ver = ipc_mmio_get_cp_version(ipc_mmio);
72-
cp_cap = readl(ipc_mmio->base + ipc_mmio->offset.cp_capability);
72+
cp_cap = ioread32(ipc_mmio->base + ipc_mmio->offset.cp_capability);
7373

7474
ipc_mmio->has_mux_lite = (ver >= IOSM_CP_VERSION) &&
7575
!(cp_cap & DL_AGGR) && !(cp_cap & UL_AGGR);
@@ -150,8 +150,8 @@ enum ipc_mem_exec_stage ipc_mmio_get_exec_stage(struct iosm_mmio *ipc_mmio)
150150
if (!ipc_mmio)
151151
return IPC_MEM_EXEC_STAGE_INVALID;
152152

153-
return (enum ipc_mem_exec_stage)readl(ipc_mmio->base +
154-
ipc_mmio->offset.exec_stage);
153+
return (enum ipc_mem_exec_stage)ioread32(ipc_mmio->base +
154+
ipc_mmio->offset.exec_stage);
155155
}
156156

157157
void ipc_mmio_copy_chip_info(struct iosm_mmio *ipc_mmio, void *dest,
@@ -167,17 +167,17 @@ enum ipc_mem_device_ipc_state ipc_mmio_get_ipc_state(struct iosm_mmio *ipc_mmio)
167167
if (!ipc_mmio)
168168
return IPC_MEM_DEVICE_IPC_INVALID;
169169

170-
return (enum ipc_mem_device_ipc_state)
171-
readl(ipc_mmio->base + ipc_mmio->offset.ipc_status);
170+
return (enum ipc_mem_device_ipc_state)ioread32(ipc_mmio->base +
171+
ipc_mmio->offset.ipc_status);
172172
}
173173

174174
enum rom_exit_code ipc_mmio_get_rom_exit_code(struct iosm_mmio *ipc_mmio)
175175
{
176176
if (!ipc_mmio)
177177
return IMEM_ROM_EXIT_FAIL;
178178

179-
return (enum rom_exit_code)readl(ipc_mmio->base +
180-
ipc_mmio->offset.rom_exit_code);
179+
return (enum rom_exit_code)ioread32(ipc_mmio->base +
180+
ipc_mmio->offset.rom_exit_code);
181181
}
182182

183183
void ipc_mmio_config(struct iosm_mmio *ipc_mmio)
@@ -202,7 +202,7 @@ void ipc_mmio_set_psi_addr_and_size(struct iosm_mmio *ipc_mmio, dma_addr_t addr,
202202
return;
203203

204204
iowrite64(addr, ipc_mmio->base + ipc_mmio->offset.psi_address);
205-
writel(size, ipc_mmio->base + ipc_mmio->offset.psi_size);
205+
iowrite32(size, ipc_mmio->base + ipc_mmio->offset.psi_size);
206206
}
207207

208208
void ipc_mmio_set_contex_info_addr(struct iosm_mmio *ipc_mmio, phys_addr_t addr)
@@ -218,6 +218,8 @@ void ipc_mmio_set_contex_info_addr(struct iosm_mmio *ipc_mmio, phys_addr_t addr)
218218

219219
int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio)
220220
{
221-
return ipc_mmio ? readl(ipc_mmio->base + ipc_mmio->offset.cp_version) :
222-
-EFAULT;
221+
if (ipc_mmio)
222+
return ioread32(ipc_mmio->base + ipc_mmio->offset.cp_version);
223+
224+
return -EFAULT;
223225
}

0 commit comments

Comments
 (0)