Skip to content

Commit ba8a86e

Browse files
Uwe Kleine-Königgregkh
authored andcommitted
leds: trigger/tty: Use led_set_brightness_sync() from workqueue
led_set_brightness() involves scheduling a workqueue. As here the led's brightness setting is done in context of the trigger's workqueue this is unjustified overhead and it's more sensible to use led_set_brightness_sync(). Fixes: fd4a641 ("leds: trigger: implement a tty trigger") Reported-by: Pavel Machek <[email protected]> Acked-by: Pavel Machek <[email protected]> Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 1487e7b commit ba8a86e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/leds/trigger/ledtrig-tty.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,12 @@ static void ledtrig_tty_work(struct work_struct *work)
122122

123123
if (icount.rx != trigger_data->rx ||
124124
icount.tx != trigger_data->tx) {
125-
led_set_brightness(trigger_data->led_cdev, LED_ON);
125+
led_set_brightness_sync(trigger_data->led_cdev, LED_ON);
126126

127127
trigger_data->rx = icount.rx;
128128
trigger_data->tx = icount.tx;
129129
} else {
130-
led_set_brightness(trigger_data->led_cdev, LED_OFF);
130+
led_set_brightness_sync(trigger_data->led_cdev, LED_OFF);
131131
}
132132

133133
out:

0 commit comments

Comments
 (0)