Skip to content

Commit c16edf5

Browse files
parakabebarino
authored andcommitted
clk: ralink: avoid to set 'CLK_IS_CRITICAL' flag for gates
'clk_init_data' for gates is setting up 'CLK_IS_CRITICAL' flag for all of them. This was being doing because some drivers of this SoC might not be ready to use the clock and we don't wanted the kernel to disable them since default behaviour without clock driver was to set all gate bits to enabled state. After a bit more testing and checking driver code it is safe to remove this flag and just let the kernel to disable those gates that are not in use. No regressions seems to appear. Fixes: 48df7a2 ("clk: ralink: add clock driver for mt7621 SoC") Signed-off-by: Sergio Paracuellos <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]>
1 parent e73f0f0 commit c16edf5

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

drivers/clk/ralink/clk-mt7621.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,7 @@ static int mt7621_gate_ops_init(struct device *dev,
131131
struct mt7621_gate *sclk)
132132
{
133133
struct clk_init_data init = {
134-
/*
135-
* Until now no clock driver existed so
136-
* these SoC drivers are not prepared
137-
* yet for the clock. We don't want kernel to
138-
* disable anything so we add CLK_IS_CRITICAL
139-
* flag here.
140-
*/
141-
.flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
134+
.flags = CLK_SET_RATE_PARENT,
142135
.num_parents = 1,
143136
.parent_names = &sclk->parent_name,
144137
.ops = &mt7621_gate_ops,

0 commit comments

Comments
 (0)