Skip to content

Commit c8dead5

Browse files
khfengjnikula
authored andcommitted
drm/i915/dp: Use max params for panels < eDP 1.4
Users reported that after commit 2bbd6db ("drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure"), the screen starts to have wobbly effect. Commit a5c936a ("drm/i915/dp: Use slow and wide link training for everything") doesn't help either, that means the affected eDP 1.2 panels only work with max params. So use max params for panels < eDP 1.4 as Windows does to solve the issue. v3: - Do the eDP rev check in intel_edp_init_dpcd() v2: - Check eDP 1.4 instead of DPCD 1.1 to apply max params Cc: [email protected] Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3714 Fixes: 2bbd6db ("drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure") Fixes: a5c936a ("drm/i915/dp: Use slow and wide link training for everything") Suggested-by: Ville Syrjälä <[email protected]> Signed-off-by: Kai-Heng Feng <[email protected]> Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit d7f213c) Signed-off-by: Jani Nikula <[email protected]>
1 parent 9af4bf2 commit c8dead5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2445,11 +2445,14 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
24452445
*/
24462446
if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,
24472447
intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==
2448-
sizeof(intel_dp->edp_dpcd))
2448+
sizeof(intel_dp->edp_dpcd)) {
24492449
drm_dbg_kms(&dev_priv->drm, "eDP DPCD: %*ph\n",
24502450
(int)sizeof(intel_dp->edp_dpcd),
24512451
intel_dp->edp_dpcd);
24522452

2453+
intel_dp->use_max_params = intel_dp->edp_dpcd[0] < DP_EDP_14;
2454+
}
2455+
24532456
/*
24542457
* This has to be called after intel_dp->edp_dpcd is filled, PSR checks
24552458
* for SET_POWER_CAPABLE bit in intel_dp->edp_dpcd[1]

0 commit comments

Comments
 (0)