Skip to content

Commit c9194f3

Browse files
committed
Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
Pull ext4 fixes from Ted Ts'o: "A regression fix, bug fix, and a comment cleanup for ext4" * tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: ext4: fix potential htree corruption when growing large_dir directories ext4: remove conflicting comment from __ext4_forget ext4: fix potential uninitialized access to retval in kmmpd
2 parents 2c4b1ec + 877ba3f commit c9194f3

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

fs/ext4/ext4_jbd2.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,6 @@ int __ext4_journal_get_write_access(const char *where, unsigned int line,
244244
* "bh" may be NULL: a metadata block may have been freed from memory
245245
* but there may still be a record of it in the journal, and that record
246246
* still needs to be revoked.
247-
*
248-
* If the handle isn't valid we're not journaling, but we still need to
249-
* call into ext4_journal_revoke() to put the buffer head.
250247
*/
251248
int __ext4_forget(const char *where, unsigned int line, handle_t *handle,
252249
int is_metadata, struct inode *inode,

fs/ext4/mmp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ static int kmmpd(void *data)
138138
unsigned mmp_check_interval;
139139
unsigned long last_update_time;
140140
unsigned long diff;
141-
int retval;
141+
int retval = 0;
142142

143143
mmp_block = le64_to_cpu(es->s_mmp_block);
144144
mmp = (struct mmp_struct *)(bh->b_data);

fs/ext4/namei.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2517,7 +2517,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
25172517
goto journal_error;
25182518
err = ext4_handle_dirty_dx_node(handle, dir,
25192519
frame->bh);
2520-
if (err)
2520+
if (restart || err)
25212521
goto journal_error;
25222522
} else {
25232523
struct dx_root *dxroot;

0 commit comments

Comments
 (0)