Skip to content

Commit c953883

Browse files
zhuyjjgunthorpe
authored andcommitted
RDMA/irdma: Change the returned type to void
Since the function irdma_sc_parse_fpm_commit_buf always returns 0, remove the returned value check and change the returned type to void. Fixes: 3f49d68 ("RDMA/irdma: Implement HW Admin Queue OPs") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Zhu Yanjun <[email protected]> Reviewed-by: Majd Dibbiny <[email protected]> Acked-by: Tatyana Nikolova <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 514305e commit c953883

File tree

1 file changed

+4
-5
lines changed
  • drivers/infiniband/hw/irdma

1 file changed

+4
-5
lines changed

drivers/infiniband/hw/irdma/ctrl.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2845,7 +2845,7 @@ static u64 irdma_sc_decode_fpm_commit(struct irdma_sc_dev *dev, __le64 *buf,
28452845
* parses fpm commit info and copy base value
28462846
* of hmc objects in hmc_info
28472847
*/
2848-
static enum irdma_status_code
2848+
static void
28492849
irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
28502850
struct irdma_hmc_obj_info *info, u32 *sd)
28512851
{
@@ -2915,7 +2915,6 @@ irdma_sc_parse_fpm_commit_buf(struct irdma_sc_dev *dev, __le64 *buf,
29152915
else
29162916
*sd = (u32)(size >> 21);
29172917

2918-
return 0;
29192918
}
29202919

29212920
/**
@@ -4434,9 +4433,9 @@ static enum irdma_status_code irdma_sc_cfg_iw_fpm(struct irdma_sc_dev *dev,
44344433
ret_code = irdma_sc_commit_fpm_val(dev->cqp, 0, hmc_info->hmc_fn_id,
44354434
&commit_fpm_mem, true, wait_type);
44364435
if (!ret_code)
4437-
ret_code = irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
4438-
hmc_info->hmc_obj,
4439-
&hmc_info->sd_table.sd_cnt);
4436+
irdma_sc_parse_fpm_commit_buf(dev, dev->fpm_commit_buf,
4437+
hmc_info->hmc_obj,
4438+
&hmc_info->sd_table.sd_cnt);
44404439
print_hex_dump_debug("HMC: COMMIT FPM BUFFER", DUMP_PREFIX_OFFSET, 16,
44414440
8, commit_fpm_mem.va, IRDMA_COMMIT_FPM_BUF_SIZE,
44424441
false);

0 commit comments

Comments
 (0)