Skip to content

Commit ca36fc4

Browse files
paravmellanoxSaeed Mahameed
authored andcommitted
net/mlx5: E-Switch, Allow setting GUID for host PF vport
E-switch should be able to set the GUID of host PF vport. Currently it returns an error. This results in below error when user attempts to configure MAC address of the PF of an external controller. $ devlink port function set pci/0000:03:00.0/196608 \ hw_addr 00:00:00:11:22:33 mlx5_core 0000:03:00.0: mlx5_esw_set_vport_mac_locked:1876:(pid 6715):\ "Failed to set vport 0 node guid, err = -22. RDMA_CM will not function properly for this VF." Check for zero vport is no longer needed. Fixes: 330077d ("net/mlx5: E-switch, Supporting setting devlink port function mac address") Signed-off-by: Yuval Avnery <[email protected]> Signed-off-by: Parav Pandit <[email protected]> Reviewed-by: Bodong Wang <[email protected]> Reviewed-by: Alaa Hleihel <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent bbc8222 commit ca36fc4

File tree

1 file changed

+0
-2
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core

1 file changed

+0
-2
lines changed

drivers/net/ethernet/mellanox/mlx5/core/vport.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,8 +465,6 @@ int mlx5_modify_nic_vport_node_guid(struct mlx5_core_dev *mdev,
465465
void *in;
466466
int err;
467467

468-
if (!vport)
469-
return -EINVAL;
470468
if (!MLX5_CAP_GEN(mdev, vport_group_manager))
471469
return -EACCES;
472470

0 commit comments

Comments
 (0)