Skip to content

Commit caace6c

Browse files
praritmattst88
authored andcommitted
alpha: Send stop IPI to send to online CPUs
This issue was noticed while debugging a shutdown issue where some secondary CPUs are not being shutdown correctly. A fix for that [1] requires that secondary cpus be offlined using the cpu_online_mask so that the stop operation is a no-op if CPU HOTPLUG is disabled. I, like the author in [1] looked at the architectures and found that alpha is one of two architectures that executes smp_send_stop() on all possible CPUs. On alpha, smp_send_stop() sends an IPI to all possible CPUs but only needs to send them to online CPUs. Send the stop IPI to only the online CPUs. [1] https://lkml.org/lkml/2020/1/10/250 Signed-off-by: Prarit Bhargava <[email protected]> Cc: Richard Henderson <[email protected]> Cc: Ivan Kokshaysky <[email protected]> Signed-off-by: Matt Turner <[email protected]>
1 parent f0443da commit caace6c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/alpha/kernel/smp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ void
582582
smp_send_stop(void)
583583
{
584584
cpumask_t to_whom;
585-
cpumask_copy(&to_whom, cpu_possible_mask);
585+
cpumask_copy(&to_whom, cpu_online_mask);
586586
cpumask_clear_cpu(smp_processor_id(), &to_whom);
587587
#ifdef DEBUG_IPI_MSG
588588
if (hard_smp_processor_id() != boot_cpu_id)

0 commit comments

Comments
 (0)