Skip to content

Commit cb3cefe

Browse files
fugangduandavem330
authored andcommitted
net: fec_ptp: add clock rate zero check
Add clock rate zero check to fix coverity issue of "divide by 0". Fixes: commit 85bd179 ("net: fec: fix spin_lock dead lock") Signed-off-by: Fugang Duan <[email protected]> Signed-off-by: Joakim Zhang <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 56b786d commit cb3cefe

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/ethernet/freescale/fec_ptp.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -604,6 +604,10 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx)
604604
fep->ptp_caps.enable = fec_ptp_enable;
605605

606606
fep->cycle_speed = clk_get_rate(fep->clk_ptp);
607+
if (!fep->cycle_speed) {
608+
fep->cycle_speed = NSEC_PER_SEC;
609+
dev_err(&fep->pdev->dev, "clk_ptp clock rate is zero\n");
610+
}
607611
fep->ptp_inc = NSEC_PER_SEC / fep->cycle_speed;
608612

609613
spin_lock_init(&fep->tmreg_lock);

0 commit comments

Comments
 (0)