Skip to content

Commit d0dcd90

Browse files
pawellcdnsPeter Chen
authored andcommitted
usb: cdnsp: Fixes incorrect value in ISOC TRB
Fixes issue with priority of operator. Operator "|" priority is higher then "? :". To improve the readability the operator "? :" has been replaced with "if ()" statement. Fixes: 3d82904 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") Reviewed-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Pawel Laszczak <[email protected]> Signed-off-by: Peter Chen <[email protected]>
1 parent a38fd87 commit d0dcd90

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/usb/cdns3/cdnsp-ring.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2197,7 +2197,10 @@ static int cdnsp_queue_isoc_tx(struct cdnsp_device *pdev,
21972197
* inverted in the first TDs isoc TRB.
21982198
*/
21992199
field = TRB_TYPE(TRB_ISOC) | TRB_TLBPC(last_burst_pkt) |
2200-
start_cycle ? 0 : 1 | TRB_SIA | TRB_TBC(burst_count);
2200+
TRB_SIA | TRB_TBC(burst_count);
2201+
2202+
if (!start_cycle)
2203+
field |= TRB_CYCLE;
22012204

22022205
/* Fill the rest of the TRB fields, and remaining normal TRBs. */
22032206
for (i = 0; i < trbs_per_td; i++) {

0 commit comments

Comments
 (0)