Skip to content

Commit d327ea1

Browse files
rfvirgilpmladek
authored andcommitted
random32: Fix implicit truncation warning in prandom_seed_state()
sparse generates the following warning: include/linux/prandom.h:114:45: sparse: sparse: cast truncates bits from constant value This is because the 64-bit seed value is manipulated and then placed in a u32, causing an implicit cast and truncation. A forced cast to u32 doesn't prevent this warning, which is reasonable because a typecast doesn't prove that truncation was expected. Logical-AND the value with 0xffffffff to make explicit that truncation to 32-bit is intended. Reported-by: kernel test robot <[email protected]> Signed-off-by: Richard Fitzgerald <[email protected]> Reviewed-by: Petr Mladek <[email protected]> Signed-off-by: Petr Mladek <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 1b93268 commit d327ea1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/prandom.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ static inline u32 __seed(u32 x, u32 m)
111111
*/
112112
static inline void prandom_seed_state(struct rnd_state *state, u64 seed)
113113
{
114-
u32 i = (seed >> 32) ^ (seed << 10) ^ seed;
114+
u32 i = ((seed >> 32) ^ (seed << 10) ^ seed) & 0xffffffffUL;
115115

116116
state->s1 = __seed(i, 2U);
117117
state->s2 = __seed(i, 8U);

0 commit comments

Comments
 (0)