Skip to content

Commit d7f237d

Browse files
committed
drm/i915/bios: Fix ports mask
PORT_A to PORT_F are regular integers defined in the enum port, while for_each_port_masked requires a bit mask for the ports. Current given mask: 0b111 Desired mask: 0b111111 I noticed this while Christoph was reporting a bug found on headless GVT configuration which bisect blamed commit 3ae04c0 ("drm/i915/bios: limit default outputs to ports A through F") v2: Avoid unnecessary line continuations as pointed by CI and Christoph Cc: Christoph Hellwig <[email protected]> Fixes: 3ae04c0 ("drm/i915/bios: limit default outputs to ports A through F") Cc: Lucas De Marchi <[email protected]> Cc: Ville Syrjälä <[email protected]> Cc: Jani Nikula <[email protected]> Signed-off-by: Rodrigo Vivi <[email protected]> Reviewed-by: José Roberto de Souza <[email protected]> Reviewed-by: Lucas De Marchi <[email protected]> Tested-by: Christoph Hellwig <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 9b52aa7) Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent ff11764 commit d7f237d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpu/drm/i915/display/intel_bios.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2166,7 +2166,8 @@ static void
21662166
init_vbt_missing_defaults(struct drm_i915_private *i915)
21672167
{
21682168
enum port port;
2169-
int ports = PORT_A | PORT_B | PORT_C | PORT_D | PORT_E | PORT_F;
2169+
int ports = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) |
2170+
BIT(PORT_D) | BIT(PORT_E) | BIT(PORT_F);
21702171

21712172
if (!HAS_DDI(i915) && !IS_CHERRYVIEW(i915))
21722173
return;

0 commit comments

Comments
 (0)