Skip to content

Commit d8201ef

Browse files
committed
Merge tag 'mailbox-v5.13' of git://git.linaro.org/landing-teams/working/fujitsu/integration
Pull mailbox updates from Jassi Brar: "qcom: - enable support for SM8350 and SC7280 sprd: - refcount channel usage - specify interrupt names in dt - support sc9863a arm: - drop redundant print ti: - convert dt-bindings to json schema and misc spelling fixes" * tag 'mailbox-v5.13' of git://git.linaro.org/landing-teams/working/fujitsu/integration: dt-bindings: mailbox: qcom-ipcc: Add compatible for SC7280 dt-bindings: mailbox: ti,secure-proxy: Convert to json schema mailbox: arm_mhu_db: Remove redundant dev_err call in mhu_db_probe() mailbox: sprd: Add supplementary inbox support dt-bindings: mailbox: Add interrupt-names to SPRD mailbox mailbox: sprd: Introduce refcnt when clients requests/free channels MAINTAINERS: Add DT bindings directory to mailbox mailbox: fix various typos in comments mailbox: pcc: fix platform_no_drv_owner.cocci warnings dt-bindings: mailbox: Add compatible for SM8350 IPCC
2 parents c969f24 + 2335f55 commit d8201ef

File tree

14 files changed

+212
-105
lines changed

14 files changed

+212
-105
lines changed

Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ properties:
2525
items:
2626
- enum:
2727
- qcom,sm8250-ipcc
28+
- qcom,sm8350-ipcc
29+
- qcom,sc7280-ipcc
2830
- const: qcom,ipcc
2931

3032
reg:

Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,23 @@ properties:
1515
compatible:
1616
enum:
1717
- sprd,sc9860-mailbox
18+
- sprd,sc9863a-mailbox
1819

1920
reg:
2021
items:
2122
- description: inbox registers' base address
2223
- description: outbox registers' base address
2324

2425
interrupts:
26+
minItems: 2
27+
maxItems: 3
28+
29+
interrupt-names:
30+
minItems: 2
2531
items:
26-
- description: inbox interrupt
27-
- description: outbox interrupt
32+
- const: inbox
33+
- const: outbox
34+
- const: supp-outbox
2835

2936
clocks:
3037
maxItems: 1
@@ -40,6 +47,7 @@ required:
4047
- compatible
4148
- reg
4249
- interrupts
50+
- interrupt-names
4351
- "#mbox-cells"
4452
- clocks
4553
- clock-names
@@ -56,5 +64,6 @@ examples:
5664
clock-names = "enable";
5765
clocks = <&aon_gate 53>;
5866
interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
67+
interrupt-names = "inbox", "outbox";
5968
};
6069
...

Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt

Lines changed: 0 additions & 50 deletions
This file was deleted.
Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
2+
%YAML 1.2
3+
---
4+
$id: http://devicetree.org/schemas/mailbox/ti,secure-proxy.yaml#
5+
$schema: http://devicetree.org/meta-schemas/core.yaml#
6+
7+
title: Texas Instruments' Secure Proxy
8+
9+
maintainers:
10+
- Nishanth Menon <[email protected]>
11+
12+
description: |
13+
The Texas Instruments' secure proxy is a mailbox controller that has
14+
configurable queues selectable at SoC(System on Chip) integration. The
15+
Message manager is broken up into different address regions that are
16+
called "threads" or "proxies" - each instance is unidirectional and is
17+
instantiated at SoC integration level by system controller to indicate
18+
receive or transmit path.
19+
20+
properties:
21+
$nodename:
22+
pattern: "^mailbox@[0-9a-f]+$"
23+
24+
compatible:
25+
const: ti,am654-secure-proxy
26+
27+
"#mbox-cells":
28+
const: 1
29+
description:
30+
Contains the secure proxy thread ID used for the specific transfer path.
31+
32+
reg-names:
33+
items:
34+
- const: target_data
35+
- const: rt
36+
- const: scfg
37+
38+
reg:
39+
minItems: 3
40+
41+
interrupt-names:
42+
minItems: 1
43+
maxItems: 100
44+
items:
45+
pattern: "^rx_[0-9]{3}$"
46+
description:
47+
Contains the interrupt name information for the Rx interrupt path for
48+
secure proxy thread in the form 'rx_<PID>'.
49+
50+
interrupts:
51+
minItems: 1
52+
maxItems: 100
53+
description:
54+
Contains the interrupt information for the Rx interrupt path for secure
55+
proxy.
56+
57+
required:
58+
- compatible
59+
- reg-names
60+
- reg
61+
- interrupt-names
62+
- interrupts
63+
- "#mbox-cells"
64+
65+
additionalProperties: false
66+
67+
examples:
68+
- |
69+
#include <dt-bindings/interrupt-controller/arm-gic.h>
70+
secure_proxy: mailbox@32c00000 {
71+
compatible = "ti,am654-secure-proxy";
72+
#mbox-cells = <1>;
73+
reg-names = "target_data", "rt", "scfg";
74+
reg = <0x32c00000 0x100000>,
75+
<0x32400000 0x100000>,
76+
<0x32800000 0x100000>;
77+
interrupt-names = "rx_011";
78+
interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
79+
};

MAINTAINERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10772,6 +10772,7 @@ S: Maintained
1077210772
F: drivers/mailbox/
1077310773
F: include/linux/mailbox_client.h
1077410774
F: include/linux/mailbox_controller.h
10775+
F: Documentation/devicetree/bindings/mailbox/
1077510776

1077610777
MAILBOX ARM MHUv2
1077710778
M: Viresh Kumar <[email protected]>

drivers/mailbox/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ config OMAP_MBOX_KFIFO_SIZE
7878
module parameter).
7979

8080
config ROCKCHIP_MBOX
81-
bool "Rockchip Soc Intergrated Mailbox Support"
81+
bool "Rockchip Soc Integrated Mailbox Support"
8282
depends on ARCH_ROCKCHIP || COMPILE_TEST
8383
help
8484
This driver provides support for inter-processor communication

drivers/mailbox/arm_mhu_db.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,10 +278,8 @@ static int mhu_db_probe(struct amba_device *adev, const struct amba_id *id)
278278
return -ENOMEM;
279279

280280
mhu->base = devm_ioremap_resource(dev, &adev->res);
281-
if (IS_ERR(mhu->base)) {
282-
dev_err(dev, "ioremap failed\n");
281+
if (IS_ERR(mhu->base))
283282
return PTR_ERR(mhu->base);
284-
}
285283

286284
chans = devm_kcalloc(dev, max_chans, sizeof(*chans), GFP_KERNEL);
287285
if (!chans)

drivers/mailbox/bcm-flexrm-mailbox.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ static void flexrm_enqueue_desc(u32 nhpos, u32 nhcnt, u32 reqid,
423423
*
424424
* In general use, number of non-HEADER descriptors can easily go
425425
* beyond 31. To tackle this situation, we have packet (or request)
426-
* extenstion bits (STARTPKT and ENDPKT) in the HEADER descriptor.
426+
* extension bits (STARTPKT and ENDPKT) in the HEADER descriptor.
427427
*
428428
* To use packet extension, the first HEADER descriptor of request
429429
* (or packet) will have STARTPKT=1 and ENDPKT=0. The intermediate
@@ -1095,7 +1095,7 @@ static int flexrm_process_completions(struct flexrm_ring *ring)
10951095
/*
10961096
* Get current completion read and write offset
10971097
*
1098-
* Note: We should read completion write pointer atleast once
1098+
* Note: We should read completion write pointer at least once
10991099
* after we get a MSI interrupt because HW maintains internal
11001100
* MSI status which will allow next MSI interrupt only after
11011101
* completion write pointer is read.

drivers/mailbox/mailbox-xgene-slimpro.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ struct slimpro_mbox_chan {
5151
/**
5252
* X-Gene SlimPRO Mailbox controller data
5353
*
54-
* X-Gene SlimPRO Mailbox controller has 8 commnunication channels.
55-
* Each channel has a separate IRQ number assgined to it.
54+
* X-Gene SlimPRO Mailbox controller has 8 communication channels.
55+
* Each channel has a separate IRQ number assigned to it.
5656
*
57-
* @mb_ctrl: Representation of the commnunication channel controller
57+
* @mb_ctrl: Representation of the communication channel controller
5858
* @mc: Array of SlimPRO mailbox channels of the controller
5959
* @chans: Array of mailbox communication channels
6060
*

drivers/mailbox/mailbox.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55

66
#define TXDONE_BY_IRQ BIT(0) /* controller has remote RTR irq */
77
#define TXDONE_BY_POLL BIT(1) /* controller can read status of last TX */
8-
#define TXDONE_BY_ACK BIT(2) /* S/W ACK recevied by Client ticks the TX */
8+
#define TXDONE_BY_ACK BIT(2) /* S/W ACK received by Client ticks the TX */
99

1010
#endif /* __MAILBOX_H */

0 commit comments

Comments
 (0)