@@ -372,11 +372,6 @@ struct tegra_pcie_port {
372
372
struct gpio_desc * reset_gpio ;
373
373
};
374
374
375
- struct tegra_pcie_bus {
376
- struct list_head list ;
377
- unsigned int nr ;
378
- };
379
-
380
375
static inline void afi_writel (struct tegra_pcie * pcie , u32 value ,
381
376
unsigned long offset )
382
377
{
@@ -764,7 +759,7 @@ static int tegra_pcie_map_irq(const struct pci_dev *pdev, u8 slot, u8 pin)
764
759
765
760
static irqreturn_t tegra_pcie_isr (int irq , void * arg )
766
761
{
767
- const char * err_msg [] = {
762
+ static const char * const err_msg [] = {
768
763
"Unknown" ,
769
764
"AXI slave error" ,
770
765
"AXI decode error" ,
@@ -2191,13 +2186,15 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
2191
2186
rp -> np = port ;
2192
2187
2193
2188
rp -> base = devm_pci_remap_cfg_resource (dev , & rp -> regs );
2194
- if (IS_ERR (rp -> base ))
2195
- return PTR_ERR (rp -> base );
2189
+ if (IS_ERR (rp -> base )) {
2190
+ err = PTR_ERR (rp -> base );
2191
+ goto err_node_put ;
2192
+ }
2196
2193
2197
2194
label = devm_kasprintf (dev , GFP_KERNEL , "pex-reset-%u" , index );
2198
2195
if (!label ) {
2199
- dev_err ( dev , "failed to create reset GPIO label\n" ) ;
2200
- return - ENOMEM ;
2196
+ err = - ENOMEM ;
2197
+ goto err_node_put ;
2201
2198
}
2202
2199
2203
2200
/*
@@ -2215,7 +2212,8 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
2215
2212
} else {
2216
2213
dev_err (dev , "failed to get reset GPIO: %ld\n" ,
2217
2214
PTR_ERR (rp -> reset_gpio ));
2218
- return PTR_ERR (rp -> reset_gpio );
2215
+ err = PTR_ERR (rp -> reset_gpio );
2216
+ goto err_node_put ;
2219
2217
}
2220
2218
}
2221
2219
@@ -2546,7 +2544,7 @@ static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
2546
2544
if (list_empty (& pcie -> ports ))
2547
2545
return NULL ;
2548
2546
2549
- seq_printf (s , "Index Status\n" );
2547
+ seq_puts (s , "Index Status\n" );
2550
2548
2551
2549
return seq_list_start (& pcie -> ports , * pos );
2552
2550
}
@@ -2583,16 +2581,16 @@ static int tegra_pcie_ports_seq_show(struct seq_file *s, void *v)
2583
2581
seq_printf (s , "%2u " , port -> index );
2584
2582
2585
2583
if (up )
2586
- seq_printf (s , "up" );
2584
+ seq_puts (s , "up" );
2587
2585
2588
2586
if (active ) {
2589
2587
if (up )
2590
- seq_printf (s , ", " );
2588
+ seq_puts (s , ", " );
2591
2589
2592
- seq_printf (s , "active" );
2590
+ seq_puts (s , "active" );
2593
2591
}
2594
2592
2595
- seq_printf (s , "\n" );
2593
+ seq_puts (s , "\n" );
2596
2594
return 0 ;
2597
2595
}
2598
2596
0 commit comments