Skip to content

Commit db2d64f

Browse files
committed
Merge branch 'remotes/lorenzo/pci/tegra'
- Remove unused struct tegra_pcie_bus (Krzysztof Wilczyński) * remotes/lorenzo/pci/tegra: PCI: tegra: make const array err_msg static PCI: tegra: Use 'seq_puts' instead of 'seq_printf' PCI: tegra: Fix OF node reference leak PCI: tegra: Remove unused struct tegra_pcie_bus
2 parents c2863b2 + fd44e8e commit db2d64f

File tree

1 file changed

+14
-16
lines changed

1 file changed

+14
-16
lines changed

drivers/pci/controller/pci-tegra.c

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -372,11 +372,6 @@ struct tegra_pcie_port {
372372
struct gpio_desc *reset_gpio;
373373
};
374374

375-
struct tegra_pcie_bus {
376-
struct list_head list;
377-
unsigned int nr;
378-
};
379-
380375
static inline void afi_writel(struct tegra_pcie *pcie, u32 value,
381376
unsigned long offset)
382377
{
@@ -764,7 +759,7 @@ static int tegra_pcie_map_irq(const struct pci_dev *pdev, u8 slot, u8 pin)
764759

765760
static irqreturn_t tegra_pcie_isr(int irq, void *arg)
766761
{
767-
const char *err_msg[] = {
762+
static const char * const err_msg[] = {
768763
"Unknown",
769764
"AXI slave error",
770765
"AXI decode error",
@@ -2191,13 +2186,15 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
21912186
rp->np = port;
21922187

21932188
rp->base = devm_pci_remap_cfg_resource(dev, &rp->regs);
2194-
if (IS_ERR(rp->base))
2195-
return PTR_ERR(rp->base);
2189+
if (IS_ERR(rp->base)) {
2190+
err = PTR_ERR(rp->base);
2191+
goto err_node_put;
2192+
}
21962193

21972194
label = devm_kasprintf(dev, GFP_KERNEL, "pex-reset-%u", index);
21982195
if (!label) {
2199-
dev_err(dev, "failed to create reset GPIO label\n");
2200-
return -ENOMEM;
2196+
err = -ENOMEM;
2197+
goto err_node_put;
22012198
}
22022199

22032200
/*
@@ -2215,7 +2212,8 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
22152212
} else {
22162213
dev_err(dev, "failed to get reset GPIO: %ld\n",
22172214
PTR_ERR(rp->reset_gpio));
2218-
return PTR_ERR(rp->reset_gpio);
2215+
err = PTR_ERR(rp->reset_gpio);
2216+
goto err_node_put;
22192217
}
22202218
}
22212219

@@ -2546,7 +2544,7 @@ static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
25462544
if (list_empty(&pcie->ports))
25472545
return NULL;
25482546

2549-
seq_printf(s, "Index Status\n");
2547+
seq_puts(s, "Index Status\n");
25502548

25512549
return seq_list_start(&pcie->ports, *pos);
25522550
}
@@ -2583,16 +2581,16 @@ static int tegra_pcie_ports_seq_show(struct seq_file *s, void *v)
25832581
seq_printf(s, "%2u ", port->index);
25842582

25852583
if (up)
2586-
seq_printf(s, "up");
2584+
seq_puts(s, "up");
25872585

25882586
if (active) {
25892587
if (up)
2590-
seq_printf(s, ", ");
2588+
seq_puts(s, ", ");
25912589

2592-
seq_printf(s, "active");
2590+
seq_puts(s, "active");
25932591
}
25942592

2595-
seq_printf(s, "\n");
2593+
seq_puts(s, "\n");
25962594
return 0;
25972595
}
25982596

0 commit comments

Comments
 (0)