Skip to content

Commit dce3d8e

Browse files
Luben Tuikovalexdeucher
authored andcommitted
drm/amdgpu: Don't query CE and UE errors
On QUERY2 IOCTL don't query counts of correctable and uncorrectable errors, since when RAS is enabled and supported on Vega20 server boards, this takes insurmountably long time, in O(n^3), which slows the system down to the point of it being unusable when we have GUI up. Fixes: ae363a2 ("drm/amdgpu: Add a new flag to AMDGPU_CTX_OP_QUERY_STATE2") Cc: Alexander Deucher <[email protected]> Cc: [email protected] Signed-off-by: Luben Tuikov <[email protected]> Reviewed-by: Alexander Deucher <[email protected]> Reviewed-by: Christian König <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 33f409e commit dce3d8e

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,6 @@ static int amdgpu_ctx_query2(struct amdgpu_device *adev,
337337
{
338338
struct amdgpu_ctx *ctx;
339339
struct amdgpu_ctx_mgr *mgr;
340-
unsigned long ras_counter;
341340

342341
if (!fpriv)
343342
return -EINVAL;
@@ -362,21 +361,6 @@ static int amdgpu_ctx_query2(struct amdgpu_device *adev,
362361
if (atomic_read(&ctx->guilty))
363362
out->state.flags |= AMDGPU_CTX_QUERY2_FLAGS_GUILTY;
364363

365-
/*query ue count*/
366-
ras_counter = amdgpu_ras_query_error_count(adev, false);
367-
/*ras counter is monotonic increasing*/
368-
if (ras_counter != ctx->ras_counter_ue) {
369-
out->state.flags |= AMDGPU_CTX_QUERY2_FLAGS_RAS_UE;
370-
ctx->ras_counter_ue = ras_counter;
371-
}
372-
373-
/*query ce count*/
374-
ras_counter = amdgpu_ras_query_error_count(adev, true);
375-
if (ras_counter != ctx->ras_counter_ce) {
376-
out->state.flags |= AMDGPU_CTX_QUERY2_FLAGS_RAS_CE;
377-
ctx->ras_counter_ce = ras_counter;
378-
}
379-
380364
mutex_unlock(&mgr->lock);
381365
return 0;
382366
}

0 commit comments

Comments
 (0)