Skip to content

Commit de1dc03

Browse files
vsyrjalamattrope
authored andcommitted
drm/i915: Move intel_modeset_all_pipes()
Move intel_modeset_all_pipes() to a central place so that we can use it elsewhere as well. No functional changes. Cc: Stanislav Lisovskiy <[email protected]> Signed-off-by: Ville Syrjälä <[email protected]> Signed-off-by: Clinton Taylor <[email protected]> Signed-off-by: Matt Roper <[email protected]> Reviewed-by: Anusha Srivatsa <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 57ed0df commit de1dc03

File tree

3 files changed

+39
-38
lines changed

3 files changed

+39
-38
lines changed

drivers/gpu/drm/i915/display/intel_cdclk.c

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -2375,44 +2375,6 @@ static int bxt_modeset_calc_cdclk(struct intel_cdclk_state *cdclk_state)
23752375
return 0;
23762376
}
23772377

2378-
static int intel_modeset_all_pipes(struct intel_atomic_state *state)
2379-
{
2380-
struct drm_i915_private *dev_priv = to_i915(state->base.dev);
2381-
struct intel_crtc *crtc;
2382-
2383-
/*
2384-
* Add all pipes to the state, and force
2385-
* a modeset on all the active ones.
2386-
*/
2387-
for_each_intel_crtc(&dev_priv->drm, crtc) {
2388-
struct intel_crtc_state *crtc_state;
2389-
int ret;
2390-
2391-
crtc_state = intel_atomic_get_crtc_state(&state->base, crtc);
2392-
if (IS_ERR(crtc_state))
2393-
return PTR_ERR(crtc_state);
2394-
2395-
if (!crtc_state->hw.active ||
2396-
drm_atomic_crtc_needs_modeset(&crtc_state->uapi))
2397-
continue;
2398-
2399-
crtc_state->uapi.mode_changed = true;
2400-
2401-
ret = drm_atomic_add_affected_connectors(&state->base,
2402-
&crtc->base);
2403-
if (ret)
2404-
return ret;
2405-
2406-
ret = intel_atomic_add_affected_planes(state, crtc);
2407-
if (ret)
2408-
return ret;
2409-
2410-
crtc_state->update_planes |= crtc_state->active_planes;
2411-
}
2412-
2413-
return 0;
2414-
}
2415-
24162378
static int fixed_modeset_calc_cdclk(struct intel_cdclk_state *cdclk_state)
24172379
{
24182380
int min_cdclk;

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9033,6 +9033,44 @@ intel_modeset_verify_disabled(struct drm_i915_private *dev_priv,
90339033
verify_disabled_dpll_state(dev_priv);
90349034
}
90359035

9036+
int intel_modeset_all_pipes(struct intel_atomic_state *state)
9037+
{
9038+
struct drm_i915_private *dev_priv = to_i915(state->base.dev);
9039+
struct intel_crtc *crtc;
9040+
9041+
/*
9042+
* Add all pipes to the state, and force
9043+
* a modeset on all the active ones.
9044+
*/
9045+
for_each_intel_crtc(&dev_priv->drm, crtc) {
9046+
struct intel_crtc_state *crtc_state;
9047+
int ret;
9048+
9049+
crtc_state = intel_atomic_get_crtc_state(&state->base, crtc);
9050+
if (IS_ERR(crtc_state))
9051+
return PTR_ERR(crtc_state);
9052+
9053+
if (!crtc_state->hw.active ||
9054+
drm_atomic_crtc_needs_modeset(&crtc_state->uapi))
9055+
continue;
9056+
9057+
crtc_state->uapi.mode_changed = true;
9058+
9059+
ret = drm_atomic_add_affected_connectors(&state->base,
9060+
&crtc->base);
9061+
if (ret)
9062+
return ret;
9063+
9064+
ret = intel_atomic_add_affected_planes(state, crtc);
9065+
if (ret)
9066+
return ret;
9067+
9068+
crtc_state->update_planes |= crtc_state->active_planes;
9069+
}
9070+
9071+
return 0;
9072+
}
9073+
90369074
static void
90379075
intel_crtc_update_active_timings(const struct intel_crtc_state *crtc_state)
90389076
{

drivers/gpu/drm/i915/display/intel_display.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -646,6 +646,7 @@ void intel_modeset_driver_remove_noirq(struct drm_i915_private *i915);
646646
void intel_modeset_driver_remove_nogem(struct drm_i915_private *i915);
647647
void intel_display_resume(struct drm_device *dev);
648648
void intel_init_pch_refclk(struct drm_i915_private *dev_priv);
649+
int intel_modeset_all_pipes(struct intel_atomic_state *state);
649650

650651
/* modesetting asserts */
651652
void assert_panel_unlocked(struct drm_i915_private *dev_priv,

0 commit comments

Comments
 (0)