Skip to content

Commit e1aba37

Browse files
matjonalexandrebelloni
authored andcommitted
rtc: cmos: remove stale REVISIT comments
It appears mc146818_get_time() and mc146818_set_time() now correctly use the century register as specified in the ACPI FADT table. It is not clear what else could be done here. These comments were introduced by commit 7be2c7c ("[PATCH] RTC framework driver for CMOS RTCs") in 2007, which originally referenced function get_rtc_time() in include/asm-generic/rtc.h . Signed-off-by: Mateusz Jończyk <[email protected]> Signed-off-by: Alexandre Belloni <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 8d448fa commit e1aba37

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

drivers/rtc/rtc-cmos.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -229,19 +229,13 @@ static int cmos_read_time(struct device *dev, struct rtc_time *t)
229229
if (!pm_trace_rtc_valid())
230230
return -EIO;
231231

232-
/* REVISIT: if the clock has a "century" register, use
233-
* that instead of the heuristic in mc146818_get_time().
234-
* That'll make Y3K compatility (year > 2070) easy!
235-
*/
236232
mc146818_get_time(t);
237233
return 0;
238234
}
239235

240236
static int cmos_set_time(struct device *dev, struct rtc_time *t)
241237
{
242-
/* REVISIT: set the "century" register if available
243-
*
244-
* NOTE: this ignores the issue whereby updating the seconds
238+
/* NOTE: this ignores the issue whereby updating the seconds
245239
* takes effect exactly 500ms after we write the register.
246240
* (Also queueing and other delays before we get this far.)
247241
*/

0 commit comments

Comments
 (0)