Skip to content

Commit e5b310f

Browse files
Michael Straussalexdeucher
authored andcommitted
drm/amd/display: Initialize lt_settings on instantiation
[WHY] lt_settings' pointers remain uninitialized but nonzero if display fails to light up with no DPCD/EDID info populated, leading to a hang on access Reviewed-by: Nicholas Kazlauskas <[email protected]> Acked-by: Mikita Lipski <[email protected]> Signed-off-by: Michael Strauss <[email protected]> Tested-by: Daniel Wheeler <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 0e62b09 commit e5b310f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1561,7 +1561,7 @@ bool dc_link_dp_perform_link_training_skip_aux(
15611561
struct dc_link *link,
15621562
const struct dc_link_settings *link_setting)
15631563
{
1564-
struct link_training_settings lt_settings;
1564+
struct link_training_settings lt_settings = {0};
15651565

15661566
dp_decide_training_settings(
15671567
link,
@@ -1707,7 +1707,7 @@ enum link_training_result dc_link_dp_perform_link_training(
17071707
bool skip_video_pattern)
17081708
{
17091709
enum link_training_result status = LINK_TRAINING_SUCCESS;
1710-
struct link_training_settings lt_settings;
1710+
struct link_training_settings lt_settings = {0};
17111711
enum dp_link_encoding encoding =
17121712
dp_get_link_encoding_format(link_settings);
17131713

@@ -1923,7 +1923,7 @@ enum link_training_result dc_link_dp_sync_lt_attempt(
19231923
struct dc_link_settings *link_settings,
19241924
struct dc_link_training_overrides *lt_overrides)
19251925
{
1926-
struct link_training_settings lt_settings;
1926+
struct link_training_settings lt_settings = {0};
19271927
enum link_training_result lt_status = LINK_TRAINING_SUCCESS;
19281928
enum dp_panel_mode panel_mode = DP_PANEL_MODE_DEFAULT;
19291929
enum clock_source_id dp_cs_id = CLOCK_SOURCE_ID_EXTERNAL;

0 commit comments

Comments
 (0)