Skip to content

Commit ef2cd42

Browse files
lumagrobclark
authored andcommitted
drm/msm/dsi: stop calling set_encoder_mode callback
None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code. Signed-off-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Abhinav Kumar <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Bjorn Andersson <[email protected]> Signed-off-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent 9b6ce7d commit ef2cd42

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

drivers/gpu/drm/msm/dsi/dsi.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,6 @@ int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev,
251251
goto fail;
252252
}
253253

254-
msm_dsi_manager_setup_encoder(msm_dsi->id);
255-
256254
priv->bridges[priv->num_bridges++] = msm_dsi->bridge;
257255
priv->connectors[priv->num_connectors++] = msm_dsi->connector;
258256

drivers/gpu/drm/msm/dsi/dsi.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 id);
8080
struct drm_connector *msm_dsi_manager_ext_bridge_init(u8 id);
8181
int msm_dsi_manager_cmd_xfer(int id, const struct mipi_dsi_msg *msg);
8282
bool msm_dsi_manager_cmd_xfer_trigger(int id, u32 dma_base, u32 len);
83-
void msm_dsi_manager_setup_encoder(int id);
8483
int msm_dsi_manager_register(struct msm_dsi *msm_dsi);
8584
void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi);
8685
bool msm_dsi_manager_validate_current_config(u8 id);

drivers/gpu/drm/msm/dsi/dsi_manager.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -215,18 +215,6 @@ static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge)
215215
return dsi_bridge->id;
216216
}
217217

218-
void msm_dsi_manager_setup_encoder(int id)
219-
{
220-
struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
221-
struct msm_drm_private *priv = msm_dsi->dev->dev_private;
222-
struct msm_kms *kms = priv->kms;
223-
struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi);
224-
225-
if (encoder && kms->funcs->set_encoder_mode)
226-
kms->funcs->set_encoder_mode(kms, encoder,
227-
msm_dsi_is_cmd_mode(msm_dsi));
228-
}
229-
230218
static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id)
231219
{
232220
struct msm_drm_private *priv = conn->dev->dev_private;

0 commit comments

Comments
 (0)