Skip to content

Commit f1ffa9d

Browse files
zhang-ruirafaeljw
authored andcommitted
Revert "ACPI: sleep: Put the FACS table after using it"
Commit 9572223 ("ACPI: sleep: Put the FACS table after using it") puts the FACS table during initialization. But the hardware signature bits in the FACS table need to be accessed, after every hibernation, to compare with the original hardware signature. So there is no reason to release the FACS table mapping after initialization. This reverts commit 9572223. An alternative solution is to use acpi_gbl_FACS variable instead, which is mapped by the ACPICA core and never released. Link: https://bugzilla.kernel.org/show_bug.cgi?id=212277 Reported-by: Stephan Hohe <[email protected]> Signed-off-by: Zhang Rui <[email protected]> Cc: 5.8+ <[email protected]> # 5.8+ Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 614124b commit f1ffa9d

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/acpi/sleep.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,10 +1009,8 @@ static void acpi_sleep_hibernate_setup(void)
10091009
return;
10101010

10111011
acpi_get_table(ACPI_SIG_FACS, 1, (struct acpi_table_header **)&facs);
1012-
if (facs) {
1012+
if (facs)
10131013
s4_hardware_signature = facs->hardware_signature;
1014-
acpi_put_table((struct acpi_table_header *)facs);
1015-
}
10161014
}
10171015
#else /* !CONFIG_HIBERNATION */
10181016
static inline void acpi_sleep_hibernate_setup(void) {}

0 commit comments

Comments
 (0)