cpufreq: arm_scmi: Fix error path when allocation failed

lukaszluba-arm · vireshk · commit f7d635883fb7 · 2021-08-04T09:31:57.000+05:30
Stop the initialization when cpumask allocation failed and return an error. Fixes: 80a064d ("scmi-cpufreq: Get opp_shared_cpus from opp-v2 for EM") Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
@@ -134,7 +134,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 	}
 
 	if (!zalloc_cpumask_var(&opp_shared_cpus, GFP_KERNEL))
-		ret = -ENOMEM;
+		return -ENOMEM;
 
 	/* Obtain CPUs that share SCMI performance controls */
 	ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus);

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`if (!zalloc_cpumask_var(&opp_shared_cpus, GFP_KERNEL))`
`137`		`- ret = -ENOMEM;`
	`137`	`+ return -ENOMEM;`
`138`	`138`
`139`	`139`	`/* Obtain CPUs that share SCMI performance controls */`
`140`	`140`	`ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus);`