char: mware: fix returnvar.cocci warnings

jing yangyang · gregkh · commit f8cefead37dd · 2021-08-27T16:20:37.000+02:00
Remove unneeded variables when "0" can be returned. Generated by: scripts/coccinelle/misc/returnvar.cocci Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn> Link: https://lore.kernel.org/r/20210820021752.10927-1-jing.yangyang@zte.com.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/char/mwave/tp3780i.c b/drivers/char/mwave/tp3780i.c
@@ -470,8 +470,6 @@ int tp3780I_StartDSP(THINKPAD_BD_DATA * pBDData)
 
 int tp3780I_QueryAbilities(THINKPAD_BD_DATA * pBDData, MW_ABILITIES * pAbilities)
 {
-	int retval = 0;
-
 	PRINTK_2(TRACE_TP3780I,
 		"tp3780i::tp3780I_QueryAbilities entry pBDData %p\n", pBDData);
 
@@ -502,7 +500,7 @@ int tp3780I_QueryAbilities(THINKPAD_BD_DATA * pBDData, MW_ABILITIES * pAbilities
 	PRINTK_1(TRACE_TP3780I,
 		"tp3780i::tp3780I_QueryAbilities exit retval=SUCCESSFUL\n");
 
-	return retval;
+	return 0;
 }
 
 int tp3780I_ReadWriteDspDStore(THINKPAD_BD_DATA * pBDData, unsigned int uOpcode,

Original file line number	Diff line number	Diff line change
`@@ -470,8 +470,6 @@ int tp3780I_StartDSP(THINKPAD_BD_DATA * pBDData)`
`470`	`470`
`471`	`471`	`int tp3780I_QueryAbilities(THINKPAD_BD_DATA * pBDData, MW_ABILITIES * pAbilities)`
`472`	`472`	`{`
`473`		`- int retval = 0;`
`474`		`-`
`475`	`473`	`PRINTK_2(TRACE_TP3780I,`
`476`	`474`	`"tp3780i::tp3780I_QueryAbilities entry pBDData %p\n", pBDData);`
`477`	`475`
`@@ -502,7 +500,7 @@ int tp3780I_QueryAbilities(THINKPAD_BD_DATA * pBDData, MW_ABILITIES * pAbilities`
`502`	`500`	`PRINTK_1(TRACE_TP3780I,`
`503`	`501`	`"tp3780i::tp3780I_QueryAbilities exit retval=SUCCESSFUL\n");`
`504`	`502`
`505`		`- return retval;`
	`503`	`+ return 0;`
`506`	`504`	`}`
`507`	`505`
`508`	`506`	`int tp3780I_ReadWriteDspDStore(THINKPAD_BD_DATA * pBDData, unsigned int uOpcode,`