Skip to content

Commit fb43ebc

Browse files
nathanchancejnikula
authored andcommitted
drm/i915/selftest: Fix use of err in igt_reset_{fail, nop}_engine()
Clang warns: In file included from drivers/gpu/drm/i915/gt/intel_reset.c:1514: drivers/gpu/drm/i915/gt/selftest_hangcheck.c:465:62: warning: variable 'err' is uninitialized when used here [-Wuninitialized] pr_err("[%s] Create context failed: %d!\n", engine->name, err); ^~~ ... drivers/gpu/drm/i915/gt/selftest_hangcheck.c:580:62: warning: variable 'err' is uninitialized when used here [-Wuninitialized] pr_err("[%s] Create context failed: %d!\n", engine->name, err); ^~~ ... 2 warnings generated. This appears to be a copy and paste issue. Use ce directly using the %pe specifier to pretty print the error code so that err is not used uninitialized in these functions. Fixes: 3a7b726 ("drm/i915/selftest: Bump selftest timeouts for hangcheck") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Nathan Chancellor <[email protected]> Reviewed-by: Joonas Lahtinen <[email protected]> Signed-off-by: Joonas Lahtinen <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit ac5a2df) Signed-off-by: Jani Nikula <[email protected]>
1 parent 2c772cf commit fb43ebc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/i915/gt/selftest_hangcheck.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ static int igt_reset_nop_engine(void *arg)
462462

463463
ce = intel_context_create(engine);
464464
if (IS_ERR(ce)) {
465-
pr_err("[%s] Create context failed: %d!\n", engine->name, err);
465+
pr_err("[%s] Create context failed: %pe!\n", engine->name, ce);
466466
return PTR_ERR(ce);
467467
}
468468

@@ -577,7 +577,7 @@ static int igt_reset_fail_engine(void *arg)
577577

578578
ce = intel_context_create(engine);
579579
if (IS_ERR(ce)) {
580-
pr_err("[%s] Create context failed: %d!\n", engine->name, err);
580+
pr_err("[%s] Create context failed: %pe!\n", engine->name, ce);
581581
return PTR_ERR(ce);
582582
}
583583

0 commit comments

Comments
 (0)