media: Revert "media: rtl28xxu: fix zero-length control request"

jhovold · mchehab · commit fe911792eae3 · 2021-07-30T12:58:21.000+02:00
This reverts commit 25d5ce3. The patch in question causes a regression and was superseded by a second version. Unfortunately, the first revision ended up being applied instead of the correct one. Link: https://lore.kernel.org/r/YL3MCGY5wTsW2kEF@hovoldconsulting.com Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
@@ -612,9 +612,8 @@ static int rtl28xxu_read_config(struct dvb_usb_device *d)
 static int rtl28xxu_identify_state(struct dvb_usb_device *d, const char **name)
 {
 	struct rtl28xxu_dev *dev = d_to_priv(d);
-	u8 buf[1];
 	int ret;
-	struct rtl28xxu_req req_demod_i2c = {0x0020, CMD_I2C_DA_RD, 1, buf};
+	struct rtl28xxu_req req_demod_i2c = {0x0020, CMD_I2C_DA_RD, 0, NULL};
 
 	dev_dbg(&d->intf->dev, "\n");
 

Original file line number	Diff line number	Diff line change
`@@ -612,9 +612,8 @@ static int rtl28xxu_read_config(struct dvb_usb_device *d)`
`612`	`612`	`static int rtl28xxu_identify_state(struct dvb_usb_device d, const char *name)`
`613`	`613`	`{`
`614`	`614`	`struct rtl28xxu_dev *dev = d_to_priv(d);`
`615`		`- u8 buf[1];`
`616`	`615`	`int ret;`
`617`		`- struct rtl28xxu_req req_demod_i2c = {0x0020, CMD_I2C_DA_RD, 1, buf};`
	`616`	`+ struct rtl28xxu_req req_demod_i2c = {0x0020, CMD_I2C_DA_RD, 0, NULL};`
`618`	`617`
`619`	`618`	`dev_dbg(&d->intf->dev, "\n");`
`620`	`619`