Skip to content

Commit fffe9be

Browse files
committed
gfs2: Delay withdraw from atomic context
Before this patch, if function __gfs2_ail_flush detected an error syncing the ail list, it call gfs2_ail_error which called gfs2_withdraw. Since __gfs2_ail_flush deals with a specific glock, we shouldn't withdraw immediately because the withdraw code (signal_our_withdraw) uses glocks in its processing. This patch changes the call from gfs2_withdraw to gfs2_withdraw_delayed which defers the withdraw until a more appropriate context, such as the logd daemon, discovers the intent to withdraw. Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Bob Peterson <[email protected]>
1 parent d1340f8 commit fffe9be

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/gfs2/glops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ static void gfs2_ail_error(struct gfs2_glock *gl, const struct buffer_head *bh)
4444
gl->gl_name.ln_type, gl->gl_name.ln_number,
4545
gfs2_glock2aspace(gl));
4646
gfs2_lm(sdp, "AIL error\n");
47-
gfs2_withdraw(sdp);
47+
gfs2_withdraw_delayed(sdp);
4848
}
4949

5050
/**

0 commit comments

Comments
 (0)