Skip to content

Commit f72b7e4

Browse files
authored
Merge pull request #2 from AltSchool/spike/nocert
Do not use bundled certs with requests library.
2 parents aeaea79 + 9868a67 commit f72b7e4

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

clever/__init__.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -315,17 +315,10 @@ def requests_request(self, meth, abs_url, headers, params):
315315

316316
try:
317317
try:
318-
# Use a CA_BUNDLE containing the following chain:
319-
# - TrustedRoot
320-
# - DigiCert High Assurance EV - 1
321-
#
322-
# This ensures that only this certificate chain is used to verify SSL certs.
323-
# Certs dervived from other ca certs will be treated as invalid.
324-
# eg. https://api.twitter.com and https://api.stripe.com FAIL
325-
# https://api.clever.com and https://api.github.com PASS
318+
# XXX April 17 2020: Verify SSL against root certs instead of bundled certs.
326319
result = requests.request(meth, abs_url,
327320
headers=headers, data=data, timeout=80,
328-
verify=CLEVER_CERTS)
321+
verify=True)
329322
except TypeError as e:
330323
raise TypeError(
331324
'Warning: It looks like your installed version of the "requests" library is not compatible with Clever\'s usage thereof. (HINT: The most likely cause is that your "requests" library is out of date. You can fix that by running "pip install -U requests".) The underlying error was: %s' % (e, ))

0 commit comments

Comments
 (0)