Restore assertions for unit tests

Author: BushraAsif

tests/Api/CallbackTest.php

@@ -162,6 +162,7 @@ public function test_can_handle_callback(): void
     {
         $call     = new Callback($this->data);
         $response = $call->call();
+        $this->assertInstanceOf(CallbackResponse::class, $response);
         $this->assertSame('d28df6b4-122d-49e2-add0-19c8271260b0', $response->paymentId);
         $this->assertSame('000000022', $response->shopOrderId);
         $this->assertSame('incomplete', $response->status);

tests/Api/CaptureReservationTest.php

@@ -54,6 +54,7 @@ public function test_capture_reservation_transactions_data(): void
         $response = $api->call();
         $this->assertInstanceOf(CaptureReservationResponse::class, $response);
         $transaction = $response->Transactions[0];
+        $this->assertInstanceOf(Transaction::class, $transaction);
         $this->assertSame('1', $transaction->TransactionId);
         $this->assertSame('978', $transaction->MerchantCurrency);
         $this->assertSame(13.37, $transaction->FraudRiskScore);

tests/Api/FundingListTest.php

@@ -77,13 +77,16 @@ public function test_funding_object(): void
         $response = $api->call();
         $this->assertInstanceOf(FundingsResponse::class, $response);
         $funding = $response->Fundings[0];
+        $this->assertInstanceOf(Funding::class, $funding);
 
         $this->assertSame('CreatedByTest', $funding->Filename);
         $this->assertSame('1234567890123456', $funding->ContractIdentifier);
         $this->assertCount(2, $funding->Shops);
         $this->assertSame('TestAcquirer', $funding->Acquirer);
+        $this->assertInstanceOf(\DateTime::class, $funding->FundingDate);
         $this->assertSame('26-09-2010', $funding->FundingDate->format('d-m-Y'));
         $this->assertSame('50.00 EUR', $funding->Amount);
+        $this->assertInstanceOf(\DateTime::class, $funding->CreatedDate);
         $this->assertSame('27-09-2010', $funding->CreatedDate->format('d-m-Y'));
         $this->assertSame('http://localhost/merchant.php/API/fundingDownload?id=1', $funding->DownloadLink);
     }

tests/Api/HeaderTest.php

@@ -34,6 +34,7 @@ public function test_get_header_error_data(): void
             $api = $this->getapi();
             $api->call();
         } catch (ResponseHeaderException $e) {
+            $this->assertInstanceOf(Header::class, $e->getHeader());
             $this->assertSame('200', $e->getHeader()->ErrorCode);
             $this->assertSame('This request has error', $e->getHeader()->ErrorMessage);
         }

tests/Api/InvoiceTextTest.php

@@ -58,11 +58,14 @@ public function test_object(): void
         $this->assertStringStartsWith('Fordringen er overdraget', $response->MandatoryInvoiceText);
         $this->assertSame('7373', $response->InvoiceNumber);
         $this->assertSame('832', $response->CustomerNumber);
+        $this->assertInstanceOf(\DateTime::class, $response->InvoiceDate);
         $this->assertSame('10-03-2011', $response->InvoiceDate->format('d-m-Y'));
+        $this->assertInstanceOf(\DateTime::class, $response->DueDate);
         $this->assertSame('24-03-2011', $response->DueDate->format('d-m-Y'));
         $this->assertCount(1, $response->TextInfos);
         $this->assertSame('Password', $response->TextInfos[0]->Name);
         $this->assertSame('xxxxxx', $response->TextInfos[0]->Value);
+        $this->assertInstanceOf(Address::class, $response->Address);
         $this->assertSame('John', $response->Address->Firstname);
         $this->assertSame('John', $response->Address->Lastname);
         $this->assertSame('Anywhere Street 12', $response->Address->Address);

tests/Api/PaymentRequestTest.php

@@ -117,6 +117,7 @@ public function test_options_url(): void
         $this->assertSame('kg', $line['unitCode']);
 
         // Config
+        $this->assertIsArray($parts['config']);
         /** @var array<string> $config */
         $config = $parts['config'];
         $this->assertSame(sprintf('%s/%s', self::CONFIG_URL, 'form'), $config['callback_form']);

tests/Api/PaymentsTest.php

@@ -73,6 +73,7 @@ public function test_payments_routing(): void
             ->setPaymentId('mypaymentid');
         $api->call();
 
+        $this->assertInstanceOf(Request::class, $api->getRawRequest());
         $this->assertInstanceOf(Response::class, $api->getRawResponse());
 
         $this->assertSame($this->getExceptedUri('payments/'), $api->getRawRequest()->getUri()->getPath());
@@ -119,6 +120,7 @@ public function test_multiple_payment_transaction_count(): void
     public function test_multiple_payment_transaction_data(): void
     {
         $data = $this->getMultiplePaymentTransaction()[0];
+        $this->assertInstanceOf(Transaction::class, $data);
 
         $this->assertSame('1', $data->TransactionId);
         $this->assertSame('ccc1479c-37f9-4962-8d2c-662d75117e9d', $data->PaymentId);
@@ -142,16 +144,24 @@ public function test_multiple_payment_transaction_data(): void
         $this->assertSame(1.00, $data->CapturedAmount);
         $this->assertSame(0.0, $data->RefundedAmount);
         $this->assertSame(0.0, $data->RecurringDefaultAmount);
+        $this->assertInstanceOf(\DateTime::class, $data->CreatedDate);
+        $this->assertInstanceOf(\DateTime::class, $data->UpdatedDate);
         $this->assertSame('28-09-2010', $data->CreatedDate->format('d-m-Y'));
         $this->assertSame('28-09-2010', $data->UpdatedDate->format('d-m-Y'));
         $this->assertSame('CreditCard', $data->PaymentNature);
         $this->assertSame('eCommerce', $data->PaymentSource);
         $this->assertSame(13.37, $data->FraudRiskScore);
         $this->assertSame('Fraud detection explanation', $data->FraudExplanation);
 
+        // Payment nature service
+        $this->assertInstanceOf(PaymentNatureService::class, $data->PaymentNatureService);
+
         // Payment Infos
         $this->assertCount(3, $data->PaymentInfos);
 
+        // Customer info
+        $this->assertInstanceOf(CustomerInfo::class, $data->CustomerInfo);
+
         // ReconciliationIdentifiers
         $this->assertCount(1, $data->ReconciliationIdentifiers);
     }
@@ -162,6 +172,7 @@ public function test_multiple_payment_transaction_data(): void
     public function test_multiple_payment_paymentnatureservice_data(): void
     {
         $data = $this->getMultiplePaymentTransaction()[0]->PaymentNatureService;
+        $this->assertInstanceOf(PaymentNatureService::class, $data);
 
         $this->assertSame('TestAcquirer', $data->name);
         $this->assertTrue($data->SupportsRefunds);
@@ -223,26 +234,36 @@ public function test_multiple_payment_customerinfo_data(): void
         $this->assertSame('support', $data->Username);
         $this->assertSame('+45 7020 0056', $data->CustomerPhone);
         $this->assertSame('12345678', $data->OrganisationNumber);
+        $this->assertInstanceOf(Country::class, $data->CountryOfOrigin);
 
         $country = $data->CountryOfOrigin;
+        $this->assertInstanceOf(Country::class, $country);
         $this->assertSame('DK', $country->Country);
         $this->assertSame('BillingAddress', $country->Source);
 
+        $this->assertInstanceOf(Address::class, $data->BillingAddress);
+
         $address = $data->BillingAddress;
+        $this->assertInstanceOf(Address::class, $address);
         $this->assertSame('Palle', $address->Firstname);
         $this->assertSame('Simonsen', $address->Lastname);
         $this->assertSame('Rosenkæret 13', $address->Address);
         $this->assertSame('Søborg', $address->City);
         $this->assertSame('2860', $address->PostalCode);
         $this->assertSame('DK', $address->Country);
 
+        $this->assertInstanceOf(Address::class, $data->ShippingAddress);
+
         $address = $data->ShippingAddress;
+        $this->assertInstanceOf(Address::class, $address);
         $this->assertNull($address->Firstname);
         $this->assertNull($address->Lastname);
         $this->assertNull($address->Address);
         $this->assertNull($address->City);
         $this->assertNull($address->PostalCode);
         $this->assertNull($address->Country);
+
+        $this->assertInstanceOf(Address::class, $data->RegisteredAddress);
     }
 
     /**
@@ -251,10 +272,12 @@ public function test_multiple_payment_customerinfo_data(): void
     public function test_multiple_payment_reconciliationidentifiers_data(): void
     {
         $data = $this->getMultiplePaymentTransaction()[0]->ReconciliationIdentifiers[0];
+        $this->assertInstanceOf(ReconciliationIdentifier::class, $data);
 
         $this->assertSame('f4e2533e-c578-4383-b075-bc8a6866784a', $data->Id);
         $this->assertSame(1.00, $data->Amount);
         $this->assertSame('captured', $data->Type);
+        $this->assertInstanceOf(\DateTime::class, $data->Date);
         $this->assertSame('28-09-2010', $data->Date->format('d-m-Y'));
         $this->assertSame('978', $data->currency);
     }

tests/Api/RefundCapturedReservationTest.php

@@ -57,6 +57,7 @@ public function test_capture_refund_transactions_data(): void
         $response = $api->call();
         $this->assertInstanceOf(RefundResponse::class, $response);
         $transaction = $response->Transactions[0];
+        $this->assertInstanceOf(Transaction::class, $transaction);
         $this->assertSame('1', $transaction->TransactionId);
         $this->assertSame('978', $transaction->MerchantCurrency);
         $this->assertSame(13.37, $transaction->FraudRiskScore);

tests/Api/TerminalsTest.php

@@ -33,6 +33,7 @@ public function test_header(): void
         $api      = $this->getTerminals();
         $response = $api->call();
         $this->assertInstanceOf(TerminalsResponse::class, $response);
+        $this->assertInstanceOf(\DateTime::class, $response->Header->Date);
         $this->assertSame('07-01-2016', $response->Header->Date->format('d-m-Y'));
         $this->assertSame('API/getTerminals', $response->Header->Path);
         $this->assertSame('0', $response->Header->ErrorCode);
@@ -60,6 +61,8 @@ public function test_response_terminal(): void
         $this->assertCount(2, $response->Terminals);
 
         $terminal = $response->Terminals[0];
+        $this->assertInstanceOf(Terminal::class, $terminal);
+        $this->assertSame('AltaPay Multi-Nature Terminal', $terminal->Title);
         $this->assertSame('DK', $terminal->Country);
         $this->assertCount(4, $terminal->Natures);
         $this->assertCount(4, $terminal->Methods);