fix: AltimateRefArgs extra fix (#32)

* AltimateRefArgs extra fix

* use AltimateMacroArgument

* change it for v11

* Add macro args test

Author: gaurpulkit

src/datapilot/core/platforms/dbt/schemas/manifest.py

@@ -438,7 +438,7 @@ class Config:
 
     name: str
     type: Optional[Optional[str]] = None
-    description: Optional[str] = ""
+    description: Optional[Optional[str]] = ""
 
 
 AltimateSupportedLanguage = SupportedLanguage

src/datapilot/core/platforms/dbt/wrappers/manifest/v10/wrapper.py

@@ -15,6 +15,7 @@
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateExternalTable
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateFileHash
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateFreshnessThreshold
+from datapilot.core.platforms.dbt.schemas.manifest import AltimateMacroArgument
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateManifestColumnInfo
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateManifestExposureNode
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateManifestMacroNode
@@ -176,7 +177,7 @@ def _get_macro(self, macro: MacroNode) -> AltimateManifestMacroNode:
             meta=macro.meta,
             docs=macro.docs,
             patch_path=macro.patch_path,
-            arguments=[AltimateRefArgs(**arg.dict()) for arg in macro.arguments] if macro.arguments else None,
+            arguments=[AltimateMacroArgument(**arg.dict()) for arg in macro.arguments] if macro.arguments else None,
             created_at=macro.created_at,
             supported_languages=macro.supported_languages,
         )

src/datapilot/core/platforms/dbt/wrappers/manifest/v11/wrapper.py

@@ -15,6 +15,7 @@
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateExternalTable
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateFileHash
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateFreshnessThreshold
+from datapilot.core.platforms.dbt.schemas.manifest import AltimateMacroArgument
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateManifestColumnInfo
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateManifestExposureNode
 from datapilot.core.platforms.dbt.schemas.manifest import AltimateManifestMacroNode
@@ -176,7 +177,7 @@ def _get_macro(self, macro: MacroNode) -> AltimateManifestMacroNode:
             meta=macro.meta,
             docs=macro.docs,
             patch_path=macro.patch_path,
-            arguments=[AltimateRefArgs(**arg.dict()) for arg in macro.arguments] if macro.arguments else None,
+            arguments=[AltimateMacroArgument(**arg.dict()) for arg in macro.arguments] if macro.arguments else None,
             created_at=macro.created_at,
             supported_languages=macro.supported_languages,
         )

tests/core/platform/dbt/test_cli.py

@@ -53,3 +53,36 @@ def test_project_health_with_only_required_arg_version1_6():
     assert result.exit_code == 0  # Ensure the command executed successfully
     # Validate behavior for when only the required argument is provided
     assert "-----------" in result.output
+
+
+def test_project_health_with_macro_args():
+    runner = CliRunner()
+    manifest_path = "tests/data/manifest_v10macroargs.json"
+
+    # Simulate command invocation without optional arguments
+    result = runner.invoke(
+        project_health,
+        [
+            "--manifest-path",
+            manifest_path,
+        ],
+    )
+
+    assert result.exit_code == 0  # Ensure the command executed successfully
+    # Validate behavior for when only the required argument is provided
+    assert "-----------" in result.output
+
+    manifest_path = "tests/data/manifest_v11macroargs.json"
+
+    # Simulate command invocation without optional arguments
+    result = runner.invoke(
+        project_health,
+        [
+            "--manifest-path",
+            manifest_path,
+        ],
+    )
+
+    assert result.exit_code == 0  # Ensure the command executed successfully
+    # Validate behavior for when only the required argument is provided
+    assert "-----------" in result.output