refactor: move domain types to domain.ts file

Author: mdesmet

src/dbt_integration/dbtIntegrationAdapter.ts

@@ -18,15 +18,11 @@ import {
 import { ProjectHealthcheck } from "./dbtCoreIntegration";
 import {
   DataPilotHealtCheckParams,
-  DocMetaMap,
-  ExposureMetaMap,
   GraphMetaMap,
-  MacroMetaMap,
-  MetricMetaMap,
-  NodeMetaMap,
-  SourceMetaMap,
+  ParsedManifest,
+  RunResultsData,
+  RunResultsEventData,
   Table,
-  TestMetaMap,
 } from "./domain";
 import { DBTConfiguration } from "./configuration";
 import { DBTFacade } from "./dbtFacade";
@@ -57,30 +53,6 @@ export const debounce = (fn: (args: unknown) => void, wait: number) => {
   };
 };
 
-export interface ParsedManifest {
-  nodeMetaMap: NodeMetaMap;
-  macroMetaMap: MacroMetaMap;
-  metricMetaMap: MetricMetaMap;
-  sourceMetaMap: SourceMetaMap;
-  graphMetaMap: GraphMetaMap;
-  testMetaMap: TestMetaMap;
-  docMetaMap: DocMetaMap;
-  exposureMetaMap: ExposureMetaMap;
-  modelDepthMap: Map<string, number>;
-}
-
-export interface RunResultsData {
-  results: Array<{
-    unique_id: string;
-  }>;
-}
-
-export interface RunResultsEventData {
-  results: Array<{
-    unique_id: string;
-  }>;
-}
-
 /**
  * DBTProjectIntegrationAdapter provides a framework-agnostic implementation of DBTFacade
  * that delegates to the appropriate dbt integration (core, cloud, fusion, corecommand)

src/dbt_integration/domain.ts

@@ -1,5 +1,3 @@
-import * as path from "path";
-
 export type MacroMetaMap = Map<string, MacroMetaData>;
 export type MetricMetaMap = Map<string, MetricMetaData>;
 export type SourceMetaMap = Map<string, SourceMetaData>;
@@ -9,6 +7,30 @@ export type DocMetaMap = Map<string, DocMetaData>;
 export type NodeMetaType = NodeMetaData;
 export type SourceMetaType = SourceTable;
 
+export interface ParsedManifest {
+  nodeMetaMap: NodeMetaMap;
+  macroMetaMap: MacroMetaMap;
+  metricMetaMap: MetricMetaMap;
+  sourceMetaMap: SourceMetaMap;
+  graphMetaMap: GraphMetaMap;
+  testMetaMap: TestMetaMap;
+  docMetaMap: DocMetaMap;
+  exposureMetaMap: ExposureMetaMap;
+  modelDepthMap: Map<string, number>;
+}
+
+export interface RunResultsData {
+  results: Array<{
+    unique_id: string;
+  }>;
+}
+
+export interface RunResultsEventData {
+  results: Array<{
+    unique_id: string;
+  }>;
+}
+
 type ConfigOption =
   | { configPath: string; configType: "Manual" }
   | {

src/manifest/dbtProject.ts

@@ -43,10 +43,7 @@ import {
   DBTCommand,
   validateSQLUsingSqlGlot,
   DBT_PROJECT_FILE,
-  RESOURCE_TYPE_ANALYSIS,
   RESOURCE_TYPE_MODEL,
-  RESOURCE_TYPE_SEED,
-  RESOURCE_TYPE_SNAPSHOT,
   RESOURCE_TYPE_SOURCE,
   MANIFEST_FILE,
   CATALOG_FILE,
@@ -64,6 +61,8 @@ import {
   ColumnMetaData,
   DataPilotHealtCheckParams,
   NodeMetaData,
+  ParsedManifest,
+  RunResultsEventData,
   Table,
 } from "../dbt_integration/domain";
 import { SharedStateService } from "../services/sharedStateService";
@@ -74,11 +73,7 @@ import { AltimateAuthService } from "../services/altimateAuthService";
 import { getProjectRelativePath } from "../utils";
 import { inject } from "inversify";
 import { DBTFacade } from "../dbt_integration/dbtFacade";
-import {
-  DBTProjectIntegrationAdapter,
-  ParsedManifest,
-  RunResultsEventData,
-} from "../dbt_integration/dbtIntegrationAdapter";
+import { DBTProjectIntegrationAdapter } from "../dbt_integration/dbtIntegrationAdapter";
 import { DBTDiagnosticData } from "../dbt_integration/diagnostics";
 
 interface FileNameTemplateMap {