Skip to content

Commit 28dba96

Browse files
committed
refactor: reorganize imports and use explicit bindings
1 parent cad7d3f commit 28dba96

File tree

115 files changed

+2152
-1200
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

115 files changed

+2152
-1200
lines changed

.prettierrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"plugins": ["prettier-plugin-organize-imports"]
3+
}

src/altimate.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
import type { RequestInit } from "node-fetch";
21
import {
2+
AltimateHttpClient,
33
ColumnMetaData,
4+
DBTConfiguration,
5+
DBTTerminal,
46
NodeMetaData,
57
SourceMetaData,
68
} from "@altimateai/dbt-integration";
7-
import { DBTTerminal } from "@altimateai/dbt-integration";
8-
import { PreconfiguredNotebookItem, NotebookItem, NotebookSchema } from "@lib";
9-
import * as vscode from "vscode";
9+
import { NotebookItem, NotebookSchema, PreconfiguredNotebookItem } from "@lib";
1010
import { inject } from "inversify";
11-
import { DBTConfiguration } from "@altimateai/dbt-integration";
12-
import { AltimateHttpClient } from "@altimateai/dbt-integration";
11+
import type { RequestInit } from "node-fetch";
12+
import * as vscode from "vscode";
1313

1414
export class UserInputError extends Error {}
1515

src/autocompletion_provider/docAutocompletionProvider.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,9 @@ import {
1313
} from "vscode";
1414
import { DBTProjectContainer } from "../manifest/dbtProjectContainer";
1515
import { ManifestCacheChangedEvent } from "../manifest/event/manifestCacheChangedEvent";
16-
import { isEnclosedWithinCodeBlock, provideSingleton } from "../utils";
1716
import { TelemetryService } from "../telemetry";
17+
import { isEnclosedWithinCodeBlock } from "../utils";
1818

19-
@provideSingleton(DocAutocompletionProvider)
2019
export class DocAutocompletionProvider
2120
implements CompletionItemProvider, Disposable
2221
{

src/autocompletion_provider/index.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
import { Disposable, DocumentFilter, languages } from "vscode";
1+
import { Disposable, languages } from "vscode";
22
import { DBTPowerUserExtension } from "../dbtPowerUserExtension";
3-
import { provideSingleton } from "../utils";
43
import { DocAutocompletionProvider } from "./docAutocompletionProvider";
54
import { MacroAutocompletionProvider } from "./macroAutocompletionProvider";
65
import { ModelAutocompletionProvider } from "./modelAutocompletionProvider";
76
import { SourceAutocompletionProvider } from "./sourceAutocompletionProvider";
87
import { UserCompletionProvider } from "./usercompletion_provider";
98

10-
@provideSingleton(AutocompletionProviders)
119
export class AutocompletionProviders implements Disposable {
1210
private disposables: Disposable[] = [];
1311

src/autocompletion_provider/macroAutocompletionProvider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ import {
1313
} from "vscode";
1414
import { DBTProjectContainer } from "../manifest/dbtProjectContainer";
1515
import { ManifestCacheChangedEvent } from "../manifest/event/manifestCacheChangedEvent";
16-
import { isEnclosedWithinCodeBlock, provideSingleton } from "../utils";
1716
import { TelemetryService } from "../telemetry";
17+
import { isEnclosedWithinCodeBlock } from "../utils";
1818

19-
@provideSingleton(MacroAutocompletionProvider) // TODO autocomplete doesn't work when mistype, delete and retype
19+
// TODO autocomplete doesn't work when mistype, delete and retype
2020
export class MacroAutocompletionProvider
2121
implements CompletionItemProvider, Disposable
2222
{

src/autocompletion_provider/modelAutocompletionProvider.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { RESOURCE_TYPE_ANALYSIS } from "@altimateai/dbt-integration";
12
import {
23
CancellationToken,
34
CompletionContext,
@@ -13,11 +14,10 @@ import {
1314
} from "vscode";
1415
import { DBTProjectContainer } from "../manifest/dbtProjectContainer";
1516
import { ManifestCacheChangedEvent } from "../manifest/event/manifestCacheChangedEvent";
16-
import { isEnclosedWithinCodeBlock, provideSingleton } from "../utils";
1717
import { TelemetryService } from "../telemetry";
18-
import { RESOURCE_TYPE_ANALYSIS } from "@altimateai/dbt-integration";
18+
import { isEnclosedWithinCodeBlock } from "../utils";
1919

20-
@provideSingleton(ModelAutocompletionProvider) // TODO autocomplete doesn't work when mistype, delete and retype
20+
// TODO autocomplete doesn't work when mistype, delete and retype
2121
export class ModelAutocompletionProvider
2222
implements CompletionItemProvider, Disposable
2323
{

src/autocompletion_provider/sourceAutocompletionProvider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ import {
1313
} from "vscode";
1414
import { DBTProjectContainer } from "../manifest/dbtProjectContainer";
1515
import { ManifestCacheChangedEvent } from "../manifest/event/manifestCacheChangedEvent";
16-
import { isEnclosedWithinCodeBlock, provideSingleton } from "../utils";
1716
import { TelemetryService } from "../telemetry";
17+
import { isEnclosedWithinCodeBlock } from "../utils";
1818

19-
@provideSingleton(SourceAutocompletionProvider) // TODO autocomplete doesn't work when mistype, delete and retype
19+
// TODO autocomplete doesn't work when mistype, delete and retype
2020
export class SourceAutocompletionProvider
2121
implements CompletionItemProvider, Disposable
2222
{

src/autocompletion_provider/usercompletion_provider.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ import {
66
Disposable,
77
ProviderResult,
88
} from "vscode";
9-
import { provideSingleton } from "../utils";
109
import { UsersService } from "../services/usersService";
1110

12-
@provideSingleton(UserCompletionProvider)
1311
export class UserCompletionProvider
1412
implements CompletionItemProvider, Disposable
1513
{

src/code_lens_provider/cteCodeLensProvider.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
1+
import { DBTTerminal } from "@altimateai/dbt-integration";
2+
import { inject } from "inversify";
13
import {
24
CancellationToken,
35
CodeLens,
46
CodeLensProvider,
57
Command,
8+
Disposable,
69
Range,
710
TextDocument,
8-
Disposable,
911
} from "vscode";
10-
import { inject } from "inversify";
11-
import { provideSingleton } from "../utils";
12-
import { DBTTerminal } from "@altimateai/dbt-integration";
1312
import { AltimateRequest } from "../altimate";
1413

1514
export interface CteInfo {
@@ -20,7 +19,6 @@ export interface CteInfo {
2019
withClauseStart: number; // Start position of the WITH clause
2120
}
2221

23-
@provideSingleton(CteCodeLensProvider)
2422
export class CteCodeLensProvider implements CodeLensProvider, Disposable {
2523
private disposables: Disposable[] = [];
2624

src/code_lens_provider/documentationCodeLensProvider.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,11 @@ import {
77
ProviderResult,
88
Range,
99
TextDocument,
10-
window,
1110
workspace,
1211
} from "vscode";
13-
import { provideSingleton } from "../utils";
1412
import { CST, LineCounter, Parser } from "yaml";
1513
import path = require("path");
1614

17-
@provideSingleton(DocumentationCodeLensProvider)
1815
export class DocumentationCodeLensProvider implements CodeLensProvider {
1916
private _onDidChangeCodeLenses: EventEmitter<void> = new EventEmitter<void>();
2017
public readonly onDidChangeCodeLenses: Event<void> =

0 commit comments

Comments
 (0)