refactor: move dbt_loom config utils to parsers module

Author: mdesmet

src/dbt_integration/parsers/modelDepthParser.ts

@@ -1,4 +1,4 @@
-import { DBTTerminal } from "../../dbt_integration/terminal";
+import { DBTTerminal } from "../terminal";
 import { DBTGraphType } from "./graphParser";
 import { DbtIntegrationClient } from "../dbtIntegrationClient";
 import { DBTConfiguration } from "../configuration";

src/dbt_integration/parsers/nodeParser.ts

@@ -1,7 +1,7 @@
 import { NodeMetaData, NodeMetaMap } from "../domain";
 import { createFullPathForNode } from "./utils";
-import { DBTTerminal } from "../../dbt_integration/terminal";
-import { getExternalProjectNamesFromDbtLoomConfig } from "../../utils";
+import { DBTTerminal } from "../terminal";
+import { getExternalProjectNamesFromDbtLoomConfig } from "./utils";
 import * as path from "path";
 import { DBTIntegrationAdapter } from "../dbtIntegrationAdapter";
 import { isResourceNode } from "../dbtIntegration";

src/dbt_integration/parsers/sourceParser.ts

@@ -1,7 +1,7 @@
 import * as path from "path";
-import { DBTTerminal } from "../../dbt_integration/terminal";
+import { DBTTerminal } from "../terminal";
 import { SourceMetaMap } from "../domain";
-import { getExternalProjectNamesFromDbtLoomConfig } from "../../utils";
+import { getExternalProjectNamesFromDbtLoomConfig } from "./utils";
 import { RESOURCE_TYPE_SOURCE } from "../dbtIntegration";
 import { DBTIntegrationAdapter } from "../dbtIntegrationAdapter";
 

src/dbt_integration/parsers/utils.ts

@@ -1,5 +1,34 @@
 import * as path from "path";
-import { existsSync } from "fs";
+import { existsSync, readFileSync } from "fs";
+import { parse } from "yaml";
+
+export const getExternalProjectNamesFromDbtLoomConfig = (
+  projectRoot: string,
+) => {
+  const dbtLoomConfigPath =
+    process.env.DBT_LOOM_CONFIG_PATH ||
+    path.join(projectRoot, "dbt_loom.config.yml");
+
+  try {
+    const fileContents = readFileSync(dbtLoomConfigPath, "utf8");
+    if (fileContents) {
+      const dbtLoomConfig = (parse(fileContents, {
+        strict: false,
+        uniqueKeys: false,
+        maxAliasCount: -1,
+      }) || {}) as { manifests?: { name: string }[] };
+
+      return dbtLoomConfig.manifests?.map((manifest) => manifest.name);
+    }
+  } catch (error) {
+    console.debug(
+      "NodeParser",
+      `Error reading dbt_loom.config.yml at ${dbtLoomConfigPath}`,
+      error,
+    );
+  }
+  return null;
+};
 
 export const createFullPathForNode: (
   projectName: string,

src/utils.ts

@@ -215,34 +215,6 @@ export const isQuotedIdentifier = (columnName: string, adapter: string) => {
   return !/^([_A-Z]+[_A-Z0-9$]*)$/.test(columnName);
 };
 
-export const getExternalProjectNamesFromDbtLoomConfig = (
-  projectRoot: string,
-) => {
-  const dbtLoomConfigPath =
-    process.env.DBT_LOOM_CONFIG_PATH ||
-    path.join(projectRoot, "dbt_loom.config.yml");
-
-  try {
-    const fileContents = readFileSync(dbtLoomConfigPath, "utf8");
-    if (fileContents) {
-      const dbtLoomConfig = (parse(fileContents, {
-        strict: false,
-        uniqueKeys: false,
-        maxAliasCount: -1,
-      }) || {}) as { manifests?: { name: string }[] };
-
-      return dbtLoomConfig.manifests?.map((manifest) => manifest.name);
-    }
-  } catch (error) {
-    console.debug(
-      "NodeParser",
-      `Error reading dbt_loom.config.yml at ${dbtLoomConfigPath}`,
-      error,
-    );
-  }
-  return null;
-};
-
 export const isRelationship = (
   metadata:
     | TestMetadataRelationships