leave formatting to sqlfmt rather than processing sqlfmt diff output

[ozgenbaris1]

Hello!

I have a bad habit of saving files by pressing ctrl + s rapidly. When I do that, formatting behaves weirdly. Some lines are swapped, some of the lines are deleted etc.

I suppose it is because of processing the sqlfmt --diff output manually here. Is there a specific reason for choosing this approach rather than not directly running sqlfmt <file> and leaving the formatting job to sqlfmt itself?

For further details, I have a simple sql file as below:

{{
    config(
        materialized='ephemeral'
    )
}}

select *
from {{ source("raw", 'foo') }}

When I run the command sqlfmt ./foo.sql here is the formatted file:

{{ config(materialized="ephemeral") }}

select *
from {{ source("raw", "foo") }}

However, if I save the file and leave the formatting to the extension itself. Here is the result:

{{ config(materialized="ephemeral") }}
from {{ source("raw", "foo") }}

select *

I don't know if it's a bug. I'd appreciate your answers.

[mdesmet]

Does this only happen if you save very quickly? I think you can just enable autosave in vscode as well, I don't remember having this issue.

Applying the diff is how formatters should work in vscode. See https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices

[mdesmet]

As you were able to locate the code, maybe you can help looking into this and potentially fixing it?

[ozgenbaris1]

do you have a guideline for contributing and testing the extension locally?

[mdesmet]

Open up the extension in vscode
Make code changes
Launch the extension in debug mode and open your favourite dbt project

[mdesmet]

I will probably add something more thorough later on in the codebase but hopefully this already gets you started!

[ozgenbaris1]

Hey, I opened #324. Can you please take a look?