Skip to content

Commit 12bc99b

Browse files
committed
fix one more test
1 parent 170e1f8 commit 12bc99b

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/Storages/ObjectStorage/DataLakes/Iceberg/Compaction.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,12 +229,14 @@ void writeDataFiles(
229229
ObjectStoragePtr object_storage,
230230
const std::optional<FormatSettings> & format_settings,
231231
ContextPtr context,
232-
StorageObjectStorageConfigurationPtr configuration)
232+
StorageObjectStorageConfigurationPtr configuration,
233+
const String & table_location,
234+
std::map<String, ObjectStoragePtr> & secondary_storages)
233235
{
234236
for (auto & [_, data_file] : initial_plan.path_to_data_file)
235237
{
236238
auto delete_file_transform = std::make_shared<IcebergBitmapPositionDeleteTransform>(
237-
sample_block, data_file->data_object_info, object_storage, format_settings, context);
239+
sample_block, data_file->data_object_info, object_storage, format_settings, context, table_location, secondary_storages);
238240

239241
StorageObjectStorage::ObjectInfo object_info(data_file->data_object_info->getPath());
240242
auto read_buffer = createReadBuffer(object_info, object_storage, context, getLogger("IcebergCompaction"));
@@ -525,7 +527,7 @@ void compactIcebergTable(
525527
if (plan.need_optimize)
526528
{
527529
auto old_files = getOldFiles(object_storage_, configuration_);
528-
writeDataFiles(plan, sample_block_, object_storage_, format_settings_, context_, configuration_);
530+
writeDataFiles(plan, sample_block_, object_storage_, format_settings_, context_, configuration_, persistent_table_components.table_location, secondary_storages_);
529531
writeMetadataFiles(plan, object_storage_, configuration_, context_, sample_block_);
530532
clearOldFiles(object_storage_, old_files);
531533
}

tests/queries/0_stateless/data_minio/field_ids_complex_test/metadata/v1.metadata.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"format-version" : 2,
33
"table-uuid" : "d4b695ca-ceeb-4537-8a2a-eee90dc6e313",
4-
"location" : "s3a://test/field_ids_struct_test",
4+
"location" : "s3a://test/field_ids_complex_test",
55
"last-sequence-number" : 1,
66
"last-updated-ms" : 1757661733693,
77
"last-column-id" : 9,
@@ -96,7 +96,7 @@
9696
"total-position-deletes" : "0",
9797
"total-equality-deletes" : "0"
9898
},
99-
"manifest-list" : "s3a://test/field_ids_struct_test/metadata/snap-607752583403487091-1-140c8dff-1d83-4841-bc40-9aa85205b555.avro",
99+
"manifest-list" : "s3a://test/field_ids_complex_test/metadata/snap-607752583403487091-1-140c8dff-1d83-4841-bc40-9aa85205b555.avro",
100100
"schema-id" : 0
101101
} ],
102102
"statistics" : [ ],

0 commit comments

Comments
 (0)