Merge pull request ClickHouse#89090 from ClickHouse/mstetsyuk-patch-1

remove try/catch from `~PooledConnection`

Author: CheSema

src/Common/HTTPConnectionPool.cpp

@@ -434,45 +434,38 @@ class EndpointConnectionPool : public std::enable_shared_from_this<EndpointConne
 
         ~PooledConnection() override
         {
-            try
+            if (bool(response_stream))
             {
-                if (bool(response_stream))
+                if (auto * fixed_steam = dynamic_cast<Poco::Net::HTTPFixedLengthInputStream *>(response_stream))
                 {
-                    if (auto * fixed_steam = dynamic_cast<Poco::Net::HTTPFixedLengthInputStream *>(response_stream))
-                    {
-                        response_stream_completed = fixed_steam->isComplete();
-                    }
-                    else if (auto * chunked_steam = dynamic_cast<Poco::Net::HTTPChunkedInputStream *>(response_stream))
-                    {
-                        response_stream_completed = chunked_steam->isComplete();
-                    }
-                    else if (auto * http_stream = dynamic_cast<Poco::Net::HTTPInputStream *>(response_stream))
-                    {
-                        response_stream_completed = http_stream->isComplete();
-                    }
-                    else
-                    {
-                        response_stream_completed = false;
-                    }
+                    response_stream_completed = fixed_steam->isComplete();
                 }
-                response_stream = nullptr;
-                Session::setSendDataHooks();
-                Session::setReceiveDataHooks();
-                Session::setSendThrottler();
-                Session::setReceiveThrottler();
+                else if (auto * chunked_steam = dynamic_cast<Poco::Net::HTTPChunkedInputStream *>(response_stream))
+                {
+                    response_stream_completed = chunked_steam->isComplete();
+                }
+                else if (auto * http_stream = dynamic_cast<Poco::Net::HTTPInputStream *>(response_stream))
+                {
+                    response_stream_completed = http_stream->isComplete();
+                }
+                else
+                {
+                    response_stream_completed = false;
+                }
+            }
+            response_stream = nullptr;
+            Session::setSendDataHooks();
+            Session::setReceiveDataHooks();
+            Session::setSendThrottler();
+            Session::setReceiveThrottler();
 
-                group->atConnectionDestroy();
+            group->atConnectionDestroy();
 
-                if (!isExpired)
-                    if (auto lock = pool.lock())
-                        lock->atConnectionDestroy(*this);
+            if (!isExpired)
+                if (auto lock = pool.lock())
+                    lock->atConnectionDestroy(*this);
 
-                CurrentMetrics::sub(metrics.active_count);
-            }
-            catch (...)
-            {
-                tryLogCurrentException(__PRETTY_FUNCTION__);
-            }
+            CurrentMetrics::sub(metrics.active_count);
         }
 
     private: